From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rock.gnat.com (rock.gnat.com [IPv6:2620:20:4000:0:a9e:1ff:fe9b:1d1]) by sourceware.org (Postfix) with ESMTP id DECC23870908 for ; Thu, 17 Sep 2020 13:57:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DECC23870908 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=brobecker@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A310656328; Thu, 17 Sep 2020 09:57:17 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 7FZmE4geicuA; Thu, 17 Sep 2020 09:57:17 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 751F356322; Thu, 17 Sep 2020 09:57:17 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id E2C8D8282A; Thu, 17 Sep 2020 06:57:15 -0700 (PDT) Date: Thu, 17 Sep 2020 06:57:15 -0700 From: Joel Brobecker To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: Problem building today's snapshot with MinGW Message-ID: <20200917135715.GK5797@adacore.com> References: <83tuw5ir09.fsf@gnu.org> <838sd87daz.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <838sd87daz.fsf@gnu.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Sep 2020 13:57:19 -0000 > > At Joel's request, I've built today's snapshot of the GDB master > > branch using mingw.org's MinGW, and found a problem when running the > > produced gdb.exe on versions of Windows older than 8.0 (in my case it > > was XP). The details are described in my report to the Gnulib folks: > > > > https://lists.gnu.org/archive/html/bug-gnulib/2020-09/index.html > > The Gnulib folks confirmed my report and provided a patch, see > > https://lists.gnu.org/archive/html/bug-gnulib/2020-09/msg00075.html > > How should we proceed? Do we import the updated Gnulib, or do we > patch our copy? I think we should take different approaches for master and branch. - On master, we should attempt a gnulib update, so as to keep out list of patches down to the absolute bare minimum. Alternatively, if there is an unforseen complication with doing that, we could include those two changes as local patches specifically, but this would only create more work for the next person who wants to do an update. That's why I think we should first try the regular update. - On the branch, I think we should go with Bruno's patches, after review and testing. gnulib updates are always tricky, so outside of some particular circumstances, I think they are in general too risky to do on a release branch. -- Joel