From: Gary Benson <gbenson@redhat.com>
To: John Baldwin <jhb@freebsd.org>
Cc: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Don't compare the pid returned from wait() against inferior_ptid.
Date: Wed, 8 Jul 2020 10:48:31 +0100 [thread overview]
Message-ID: <20200708094831.GA9636@blade.nx> (raw)
In-Reply-To: <20200708004605.91238-1-jhb@FreeBSD.org>
Hi John,
John Baldwin wrote:
> inf_ptrace::wait() needs to discard termination events reported by
> detached child processes. Previously it compared the returned pid
> against the pid in inferior_ptid to determine if a termination event
> should be discarded or reported. inferior_ptid is now null_ptid in
> wait() target methods, so this was always failing and never
> reporting exit events. Instead, report termination events whose pid
> matches any inferior belonging to the current target.
>
> gdb/ChangeLog:
>
> * inf-ptrace.c (inf_ptrace_target::wait): Don't compare against
> inferior_ptid.
Did the bug you've fixed cause any tests to fail? And, if not, is
this something it's possible to write a test for?
Cheers,
Gary
--
Gary Benson - he / him / his
Principal Software Engineer, Red Hat
next prev parent reply other threads:[~2020-07-08 9:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 0:46 John Baldwin
2020-07-08 9:48 ` Gary Benson [this message]
2020-07-08 16:46 ` John Baldwin
2020-07-08 16:52 ` Simon Marchi
2020-07-09 16:37 ` John Baldwin
2020-07-09 17:34 ` Eli Zaretskii
2020-07-08 18:40 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708094831.GA9636@blade.nx \
--to=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jhb@freebsd.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox