From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id 1D3BD386180A for ; Wed, 8 Jul 2020 09:48:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1D3BD386180A Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-208-Zvq8RyLkMKegYLY7F72r4g-1; Wed, 08 Jul 2020 05:48:33 -0400 X-MC-Unique: Zvq8RyLkMKegYLY7F72r4g-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E7843EC1AC; Wed, 8 Jul 2020 09:48:32 +0000 (UTC) Received: from blade.nx (ovpn-114-154.ams2.redhat.com [10.36.114.154]) by smtp.corp.redhat.com (Postfix) with ESMTP id B932679809; Wed, 8 Jul 2020 09:48:32 +0000 (UTC) Received: by blade.nx (Postfix, from userid 1000) id E72FB816CCA9; Wed, 8 Jul 2020 10:48:31 +0100 (BST) Date: Wed, 8 Jul 2020 10:48:31 +0100 From: Gary Benson To: John Baldwin Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCH] Don't compare the pid returned from wait() against inferior_ptid. Message-ID: <20200708094831.GA9636@blade.nx> References: <20200708004605.91238-1-jhb@FreeBSD.org> MIME-Version: 1.0 In-Reply-To: <20200708004605.91238-1-jhb@FreeBSD.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jul 2020 09:48:37 -0000 Hi John, John Baldwin wrote: > inf_ptrace::wait() needs to discard termination events reported by > detached child processes. Previously it compared the returned pid > against the pid in inferior_ptid to determine if a termination event > should be discarded or reported. inferior_ptid is now null_ptid in > wait() target methods, so this was always failing and never > reporting exit events. Instead, report termination events whose pid > matches any inferior belonging to the current target. > > gdb/ChangeLog: > > * inf-ptrace.c (inf_ptrace_target::wait): Don't compare against > inferior_ptid. Did the bug you've fixed cause any tests to fail? And, if not, is this something it's possible to write a test for? Cheers, Gary -- Gary Benson - he / him / his Principal Software Engineer, Red Hat