Re: [PATCH] Don't compare the pid returned from wait() against inferior_ptid.

[John Baldwin <jhb@FreeBSD.org>]

On 7/8/20 2:48 AM, Gary Benson wrote:
> Hi John,
> 
> John Baldwin wrote:
>> inf_ptrace::wait() needs to discard termination events reported by
>> detached child processes.  Previously it compared the returned pid
>> against the pid in inferior_ptid to determine if a termination event
>> should be discarded or reported.  inferior_ptid is now null_ptid in
>> wait() target methods, so this was always failing and never
>> reporting exit events.  Instead, report termination events whose pid
>> matches any inferior belonging to the current target.
>>
>> gdb/ChangeLog:
>>
>> 	* inf-ptrace.c (inf_ptrace_target::wait): Don't compare against
>> 	inferior_ptid.
> 
> Did the bug you've fixed cause any tests to fail?  And, if not, is
> this something it's possible to write a test for?

It did cause regressions in some tests on FreeBSD.  I am still letting
a before-after testsuite run, but gdb.base/a2-run.exp at least failed
all tests due to this bug and is back to passing on FreeBSD with the fix.

-- 
John Baldwin