From: Eli Zaretskii <eliz@gnu.org>
To: John Baldwin <jhb@FreeBSD.org>
Cc: simark@simark.ca, gbenson@redhat.com, palves@redhat.com,
gdb-patches@sourceware.org
Subject: Re: [PATCH] Don't compare the pid returned from wait() against inferior_ptid.
Date: Thu, 09 Jul 2020 20:34:12 +0300 [thread overview]
Message-ID: <83v9iwpp7v.fsf@gnu.org> (raw)
In-Reply-To: <37dfa87e-e71b-2357-e140-02f6fd40160c@FreeBSD.org> (message from John Baldwin on Thu, 9 Jul 2020 09:37:05 -0700)
> From: John Baldwin <jhb@FreeBSD.org>
> Date: Thu, 9 Jul 2020 09:37:05 -0700
> Cc: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
>
> Don't compare the pid returned from wait() against inferior_ptid.
>
> inf_ptrace::wait() needs to discard termination events reported by
> detached child processes. Previously it compared the returned pid
> against the pid in inferior_ptid to determine if a termination event
> should be discarded or reported. The multi-target changes cleared
> inferior_ptid to null_ptid in wait() target methods, so this was
> always failing and never reporting exit events. Instead, report
> termination events whose pid matches any inferior belonging to the
> current target.
Thanks.
Please allow me a minor stylistic nit: using "foo()" to indicate a
function call is suboptimal, and potentially confusing: it looks like
calling a function with no arguments, which is not what you want. It
is better to use 'foo' instead.
next prev parent reply other threads:[~2020-07-09 17:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 0:46 John Baldwin
2020-07-08 9:48 ` Gary Benson
2020-07-08 16:46 ` John Baldwin
2020-07-08 16:52 ` Simon Marchi
2020-07-09 16:37 ` John Baldwin
2020-07-09 17:34 ` Eli Zaretskii [this message]
2020-07-08 18:40 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83v9iwpp7v.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
--cc=palves@redhat.com \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox