[PATCH][gdb/testsuite] Set EDITOR to true before using edit

[PATCH][gdb/testsuite] Set EDITOR to true before using edit

[Tom de Vries]

Hi,

The test-case gdb.base/list-ambiguous.exp normally passes, but with target
board readnow, some tests fail.

In particular, for this test, edit doesn't fail as expected:
...
    # While at it, test the "edit" command as well, since it shares
    # code with "list".
    gdb_test "edit $symbol" \
        "Specified line is ambiguous:\r\n${h0_re}\r\n${h1_re}"
...
and the editor is launched, in my case:
...
$ echo $EDITOR
/home/vries/bin/emacs-nw.sh
...
which result in all subsequent tests failing with timeout, and an editor
backup file in my sources:
...
$ git status --ignored
On branch master
Ignored files:
  (use "git add -f <file>..." to include in what will be committed)

        gdb/testsuite/gdb.base/#list-ambiguous0.c#

nothing to commit, working tree clean
...

Fix this by setting EDITOR to true before starting gdb in this test-case.

Tested on x86_64-linux.

OK for trunk?

Thanks,
- Tom

[gdb/testsuite] Set EDITOR to true before using edit

gdb/testsuite/ChangeLog:

2020-03-10  Tom de Vries  <tdevries@suse.de>

	* gdb.base/list-ambiguous.exp: Set EDITOR to true.

---
 gdb/testsuite/gdb.base/list-ambiguous.exp | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gdb/testsuite/gdb.base/list-ambiguous.exp b/gdb/testsuite/gdb.base/list-ambiguous.exp
index 8d63938fb7..0c89bba3a1 100644
--- a/gdb/testsuite/gdb.base/list-ambiguous.exp
+++ b/gdb/testsuite/gdb.base/list-ambiguous.exp
@@ -18,6 +18,8 @@
 
 standard_testfile list-ambiguous0.c list-ambiguous1.c
 
+setenv EDITOR true
+
 if {[prepare_for_testing "failed to prepare" $testfile [list $srcfile $srcfile2] \
 	 {debug}]} {
     return -1

Re: [PATCH][gdb/testsuite] Set EDITOR to true before using edit

[Tom Tromey]

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> [gdb/testsuite] Set EDITOR to true before using edit

Tom> gdb/testsuite/ChangeLog:

Tom> 2020-03-10  Tom de Vries  <tdevries@suse.de>

Tom> 	* gdb.base/list-ambiguous.exp: Set EDITOR to true.

Thanks, this is ok.

Tom

Re: [PATCH][gdb/testsuite] Set EDITOR to true before using edit

[Simon Marchi]

On 2020-03-10 12:32 p.m., Tom de Vries wrote:
> Hi,
> 
> The test-case gdb.base/list-ambiguous.exp normally passes, but with target
> board readnow, some tests fail.
> 
> In particular, for this test, edit doesn't fail as expected:
> ...
>     # While at it, test the "edit" command as well, since it shares
>     # code with "list".
>     gdb_test "edit $symbol" \
>         "Specified line is ambiguous:\r\n${h0_re}\r\n${h1_re}"
> ...
> and the editor is launched, in my case:
> ...
> $ echo $EDITOR
> /home/vries/bin/emacs-nw.sh
> ...
> which result in all subsequent tests failing with timeout, and an editor
> backup file in my sources:
> ...
> $ git status --ignored
> On branch master
> Ignored files:
>   (use "git add -f <file>..." to include in what will be committed)
> 
>         gdb/testsuite/gdb.base/#list-ambiguous0.c#
> 
> nothing to commit, working tree clean
> ...
> 
> Fix this by setting EDITOR to true before starting gdb in this test-case.
> 
> Tested on x86_64-linux.
> 
> OK for trunk?
> 
> Thanks,
> - Tom
> 
> [gdb/testsuite] Set EDITOR to true before using edit
> 
> gdb/testsuite/ChangeLog:
> 
> 2020-03-10  Tom de Vries  <tdevries@suse.de>
> 
> 	* gdb.base/list-ambiguous.exp: Set EDITOR to true.
> 
> ---
>  gdb/testsuite/gdb.base/list-ambiguous.exp | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/gdb/testsuite/gdb.base/list-ambiguous.exp b/gdb/testsuite/gdb.base/list-ambiguous.exp
> index 8d63938fb7..0c89bba3a1 100644
> --- a/gdb/testsuite/gdb.base/list-ambiguous.exp
> +++ b/gdb/testsuite/gdb.base/list-ambiguous.exp
> @@ -18,6 +18,8 @@
>  
>  standard_testfile list-ambiguous0.c list-ambiguous1.c
>  
> +setenv EDITOR true
> +
>  if {[prepare_for_testing "failed to prepare" $testfile [list $srcfile $srcfile2] \
>  	 {debug}]} {
>      return -1
> 

That's a fun one :).

This is fine, but please add a comment on top of your setenv to explain why
it's there.

Simon