From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 87EDA385C019 for ; Wed, 11 Mar 2020 05:10:06 +0000 (GMT) Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 069811E4A5; Wed, 11 Mar 2020 01:10:05 -0400 (EDT) Subject: Re: [PATCH][gdb/testsuite] Set EDITOR to true before using edit To: Tom de Vries , gdb-patches@sourceware.org References: <20200310163222.GA2202@delia> From: Simon Marchi Message-ID: Date: Wed, 11 Mar 2020 01:10:05 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200310163222.GA2202@delia> Content-Type: text/plain; charset=utf-8 Content-Language: en-US-large Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Mar 2020 05:10:07 -0000 On 2020-03-10 12:32 p.m., Tom de Vries wrote: > Hi, > > The test-case gdb.base/list-ambiguous.exp normally passes, but with target > board readnow, some tests fail. > > In particular, for this test, edit doesn't fail as expected: > ... > # While at it, test the "edit" command as well, since it shares > # code with "list". > gdb_test "edit $symbol" \ > "Specified line is ambiguous:\r\n${h0_re}\r\n${h1_re}" > ... > and the editor is launched, in my case: > ... > $ echo $EDITOR > /home/vries/bin/emacs-nw.sh > ... > which result in all subsequent tests failing with timeout, and an editor > backup file in my sources: > ... > $ git status --ignored > On branch master > Ignored files: > (use "git add -f ..." to include in what will be committed) > > gdb/testsuite/gdb.base/#list-ambiguous0.c# > > nothing to commit, working tree clean > ... > > Fix this by setting EDITOR to true before starting gdb in this test-case. > > Tested on x86_64-linux. > > OK for trunk? > > Thanks, > - Tom > > [gdb/testsuite] Set EDITOR to true before using edit > > gdb/testsuite/ChangeLog: > > 2020-03-10 Tom de Vries > > * gdb.base/list-ambiguous.exp: Set EDITOR to true. > > --- > gdb/testsuite/gdb.base/list-ambiguous.exp | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/gdb/testsuite/gdb.base/list-ambiguous.exp b/gdb/testsuite/gdb.base/list-ambiguous.exp > index 8d63938fb7..0c89bba3a1 100644 > --- a/gdb/testsuite/gdb.base/list-ambiguous.exp > +++ b/gdb/testsuite/gdb.base/list-ambiguous.exp > @@ -18,6 +18,8 @@ > > standard_testfile list-ambiguous0.c list-ambiguous1.c > > +setenv EDITOR true > + > if {[prepare_for_testing "failed to prepare" $testfile [list $srcfile $srcfile2] \ > {debug}]} { > return -1 > That's a fun one :). This is fine, but please add a comment on top of your setenv to explain why it's there. Simon