From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 4D30A395341E for ; Tue, 10 Mar 2020 16:32:26 +0000 (GMT) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 5E922AC84 for ; Tue, 10 Mar 2020 16:32:25 +0000 (UTC) Date: Tue, 10 Mar 2020 17:32:23 +0100 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH][gdb/testsuite] Set EDITOR to true before using edit Message-ID: <20200310163222.GA2202@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Mar 2020 16:32:27 -0000 Hi, The test-case gdb.base/list-ambiguous.exp normally passes, but with target board readnow, some tests fail. In particular, for this test, edit doesn't fail as expected: ... # While at it, test the "edit" command as well, since it shares # code with "list". gdb_test "edit $symbol" \ "Specified line is ambiguous:\r\n${h0_re}\r\n${h1_re}" ... and the editor is launched, in my case: ... $ echo $EDITOR /home/vries/bin/emacs-nw.sh ... which result in all subsequent tests failing with timeout, and an editor backup file in my sources: ... $ git status --ignored On branch master Ignored files: (use "git add -f ..." to include in what will be committed) gdb/testsuite/gdb.base/#list-ambiguous0.c# nothing to commit, working tree clean ... Fix this by setting EDITOR to true before starting gdb in this test-case. Tested on x86_64-linux. OK for trunk? Thanks, - Tom [gdb/testsuite] Set EDITOR to true before using edit gdb/testsuite/ChangeLog: 2020-03-10 Tom de Vries * gdb.base/list-ambiguous.exp: Set EDITOR to true. --- gdb/testsuite/gdb.base/list-ambiguous.exp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gdb/testsuite/gdb.base/list-ambiguous.exp b/gdb/testsuite/gdb.base/list-ambiguous.exp index 8d63938fb7..0c89bba3a1 100644 --- a/gdb/testsuite/gdb.base/list-ambiguous.exp +++ b/gdb/testsuite/gdb.base/list-ambiguous.exp @@ -18,6 +18,8 @@ standard_testfile list-ambiguous0.c list-ambiguous1.c +setenv EDITOR true + if {[prepare_for_testing "failed to prepare" $testfile [list $srcfile $srcfile2] \ {debug}]} { return -1