From: "Simon Marchi (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: [review v2] [gdb/testsuite] Make inferior_exited_re match a single line
Date: Tue, 04 Feb 2020 14:23:00 -0000 [thread overview]
Message-ID: <20200204142302.7A1862816C@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1580742892000.Id7b1dcecd8c7fda3d1ab34b4fa1364d301748333@gnutoolchain-gerrit.osci.io>
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/764
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
| --- gdb/testsuite/lib/gdb.exp
| +++ gdb/testsuite/lib/gdb.exp
| @@ -112,18 +112,18 @@ global env
| if ![info exists env(EXEEXT)] {
| set EXEEXT ""
| } else {
| set EXEEXT $env(EXEEXT)
| }
|
| set octal "\[0-7\]+"
|
| -set inferior_exited_re "(?:\\\[Inferior \[0-9\]+ \\(.*\\) exited)"
| +set inferior_exited_re "(?:\\\[Inferior \[0-9\]+ \\(\[^\n\r]*\\) exited)"
PS1, Line 120:
Eh, you're right, what I said didn't make sense. We escape the
opening bracket so it's not interpreted as a procedure call, so it can
be interpreted as a character group. But still, it's the same: if
there's an unescaped closing bracket that doesn't match any unescaped
opening bracket, tcl will treat it as a regular character.
|
| # A regular expression that matches a value history number.
| # E.g., $1, $2, etc.
| set valnum_re "\\\$$decimal"
|
| ### Only procedures should come after this point.
|
| #
| # gdb_version -- extract and print the version number of GDB
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Id7b1dcecd8c7fda3d1ab34b4fa1364d301748333
Gerrit-Change-Number: 764
Gerrit-PatchSet: 2
Gerrit-Owner: Tom de Vries <tdevries@suse.de>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Tom de Vries <tdevries@suse.de>
Gerrit-Comment-Date: Tue, 04 Feb 2020 14:23:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tom de Vries <tdevries@suse.de>
Comment-In-Reply-To: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-MessageType: comment
next prev parent reply other threads:[~2020-02-04 14:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 15:15 [review] " Tom de Vries (Code Review)
2020-02-04 4:38 ` Simon Marchi (Code Review)
2020-02-04 9:31 ` Tom de Vries (Code Review)
2020-02-04 9:32 ` [review v2] " Tom de Vries (Code Review)
2020-02-04 14:23 ` Simon Marchi (Code Review) [this message]
2020-02-04 16:32 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2020-02-04 16:32 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200204142302.7A1862816C@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=gdb-patches@sourceware.org \
--cc=gnutoolchain-gerrit@osci.io \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox