From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110747 invoked by alias); 4 Feb 2020 14:23:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 110730 invoked by uid 89); 4 Feb 2020 14:23:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Feb 2020 14:23:05 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id B3E1A2046F; Tue, 4 Feb 2020 09:23:03 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id ACA4C20184; Tue, 4 Feb 2020 09:23:02 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 7A1862816C; Tue, 4 Feb 2020 09:23:02 -0500 (EST) X-Gerrit-PatchSet: 2 Date: Tue, 04 Feb 2020 14:23:00 -0000 From: "Simon Marchi (Code Review)" To: Tom de Vries , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v2] [gdb/testsuite] Make inferior_exited_re match a single line X-Gerrit-Change-Id: Id7b1dcecd8c7fda3d1ab34b4fa1364d301748333 X-Gerrit-Change-Number: 764 X-Gerrit-ChangeURL: X-Gerrit-Commit: e42a7e4b222fbfb11e918080a77e3a0a9deb3e10 In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 4 Feb 2020 09:23:02 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20200204142302.7A1862816C@gnutoolchain-gerrit.osci.io> X-SW-Source: 2020-02/txt/msg00065.txt.bz2 Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/764 ...................................................................... Patch Set 2: Code-Review+2 (1 comment) | --- gdb/testsuite/lib/gdb.exp | +++ gdb/testsuite/lib/gdb.exp | @@ -112,18 +112,18 @@ global env | if ![info exists env(EXEEXT)] { | set EXEEXT "" | } else { | set EXEEXT $env(EXEEXT) | } | | set octal "\[0-7\]+" | | -set inferior_exited_re "(?:\\\[Inferior \[0-9\]+ \\(.*\\) exited)" | +set inferior_exited_re "(?:\\\[Inferior \[0-9\]+ \\(\[^\n\r]*\\) exited)" PS1, Line 120: Eh, you're right, what I said didn't make sense. We escape the opening bracket so it's not interpreted as a procedure call, so it can be interpreted as a character group. But still, it's the same: if there's an unescaped closing bracket that doesn't match any unescaped opening bracket, tcl will treat it as a regular character. | | # A regular expression that matches a value history number. | # E.g., $1, $2, etc. | set valnum_re "\\\$$decimal" | | ### Only procedures should come after this point. | | # | # gdb_version -- extract and print the version number of GDB -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Id7b1dcecd8c7fda3d1ab34b4fa1364d301748333 Gerrit-Change-Number: 764 Gerrit-PatchSet: 2 Gerrit-Owner: Tom de Vries Gerrit-Reviewer: Simon Marchi Gerrit-Reviewer: Tom de Vries Gerrit-Comment-Date: Tue, 04 Feb 2020 14:23:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Tom de Vries Comment-In-Reply-To: Simon Marchi Gerrit-MessageType: comment