[review] [gdb/testsuite] Make inferior_exited_re match a single line

["Simon Marchi (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/764
......................................................................


Patch Set 1:

(1 comment)

| --- gdb/testsuite/lib/gdb.exp
| +++ gdb/testsuite/lib/gdb.exp
| @@ -112,18 +112,18 @@ global env
|  if ![info exists env(EXEEXT)] {
|      set EXEEXT ""
|  } else {
|      set EXEEXT $env(EXEEXT)
|  }
|  
|  set octal "\[0-7\]+"
|  
| -set inferior_exited_re "(?:\\\[Inferior \[0-9\]+ \\(.*\\) exited)"
| +set inferior_exited_re "(?:\\\[Inferior \[0-9\]+ \\(\[^\n\r]*\\) exited)"

PS1, Line 120:

Usually I would escape the closing square bracket, like what is done
in `\[0-9\]` just before on the same line.  But I presume it's not
strictly necessary, and that the regexp engine sees that this closing
bracket doesn't match any opening bracket, and therefore treats it
like a normal character?

For consistency, I would suggest escaping it, but the patch LGTM
either way.

|  
|  # A regular expression that matches a value history number.
|  # E.g., $1, $2, etc.
|  set valnum_re "\\\$$decimal"
|  
|  ### Only procedures should come after this point.
|  
|  #
|  # gdb_version -- extract and print the version number of GDB

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Id7b1dcecd8c7fda3d1ab34b4fa1364d301748333
Gerrit-Change-Number: 764
Gerrit-PatchSet: 1
Gerrit-Owner: Tom de Vries <tdevries@suse.de>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Tue, 04 Feb 2020 04:38:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment