[review] [gdb/testsuite] Make inferior_exited_re match a single line

["Tom de Vries (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Tom de Vries has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/764
......................................................................


Patch Set 1:

(1 comment)

| --- gdb/testsuite/lib/gdb.exp
| +++ gdb/testsuite/lib/gdb.exp
| @@ -112,18 +112,18 @@ global env
|  if ![info exists env(EXEEXT)] {
|      set EXEEXT ""
|  } else {
|      set EXEEXT $env(EXEEXT)
|  }
|  
|  set octal "\[0-7\]+"
|  
| -set inferior_exited_re "(?:\\\[Inferior \[0-9\]+ \\(.*\\) exited)"
| +set inferior_exited_re "(?:\\\[Inferior \[0-9\]+ \\(\[^\n\r]*\\) exited)"

PS1, Line 120:

It was a typo, thanks for noticing that. I've retested and will submit
the updated patch.

I've tried to understand why not escaping the closing square bracket
still works, and I think it happens before a string is interpreted as
regexp, in the substitutions.

The escape of the opening square bracket prevents command
substitution, but after substitution is done we're left with the same
string, whether we escaped the closing square bracket or not:
...
$ tclsh
% set line1 "\[bla]"
[bla]
% set line2 "\[bla\]"
[bla]
% string equal $line1 $line2
1
...

|  
|  # A regular expression that matches a value history number.
|  # E.g., $1, $2, etc.
|  set valnum_re "\\\$$decimal"
|  
|  ### Only procedures should come after this point.
|  
|  #
|  # gdb_version -- extract and print the version number of GDB

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Id7b1dcecd8c7fda3d1ab34b4fa1364d301748333
Gerrit-Change-Number: 764
Gerrit-PatchSet: 1
Gerrit-Owner: Tom de Vries <tdevries@suse.de>
Gerrit-Reviewer: Tom de Vries <tdevries@suse.de>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Tue, 04 Feb 2020 09:31:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-MessageType: comment