From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34388 invoked by alias); 4 Feb 2020 09:31:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 34351 invoked by uid 89); 4 Feb 2020 09:31:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Feb 2020 09:31:40 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id B2C692039A; Tue, 4 Feb 2020 04:31:38 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 95A18202F2; Tue, 4 Feb 2020 04:31:37 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 7A96A2816C; Tue, 4 Feb 2020 04:31:37 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Tue, 04 Feb 2020 09:31:00 -0000 From: "Tom de Vries (Code Review)" To: gdb-patches@sourceware.org Cc: Simon Marchi Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] [gdb/testsuite] Make inferior_exited_re match a single line X-Gerrit-Change-Id: Id7b1dcecd8c7fda3d1ab34b4fa1364d301748333 X-Gerrit-Change-Number: 764 X-Gerrit-ChangeURL: X-Gerrit-Commit: a5a066e7cebc957d9478397fc98aea904965cd2b In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 4 Feb 2020 04:31:37 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20200204093137.7A96A2816C@gnutoolchain-gerrit.osci.io> X-SW-Source: 2020-02/txt/msg00062.txt.bz2 Tom de Vries has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/764 ...................................................................... Patch Set 1: (1 comment) | --- gdb/testsuite/lib/gdb.exp | +++ gdb/testsuite/lib/gdb.exp | @@ -112,18 +112,18 @@ global env | if ![info exists env(EXEEXT)] { | set EXEEXT "" | } else { | set EXEEXT $env(EXEEXT) | } | | set octal "\[0-7\]+" | | -set inferior_exited_re "(?:\\\[Inferior \[0-9\]+ \\(.*\\) exited)" | +set inferior_exited_re "(?:\\\[Inferior \[0-9\]+ \\(\[^\n\r]*\\) exited)" PS1, Line 120: It was a typo, thanks for noticing that. I've retested and will submit the updated patch. I've tried to understand why not escaping the closing square bracket still works, and I think it happens before a string is interpreted as regexp, in the substitutions. The escape of the opening square bracket prevents command substitution, but after substitution is done we're left with the same string, whether we escaped the closing square bracket or not: ... $ tclsh % set line1 "\[bla]" [bla] % set line2 "\[bla\]" [bla] % string equal $line1 $line2 1 ... | | # A regular expression that matches a value history number. | # E.g., $1, $2, etc. | set valnum_re "\\\$$decimal" | | ### Only procedures should come after this point. | | # | # gdb_version -- extract and print the version number of GDB -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Id7b1dcecd8c7fda3d1ab34b4fa1364d301748333 Gerrit-Change-Number: 764 Gerrit-PatchSet: 1 Gerrit-Owner: Tom de Vries Gerrit-Reviewer: Tom de Vries Gerrit-CC: Simon Marchi Gerrit-Comment-Date: Tue, 04 Feb 2020 09:31:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Simon Marchi Gerrit-MessageType: comment