From: "Tom Tromey (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Christian Biesinger <cbiesinger@google.com>, gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@polymtl.ca>
Subject: [review] Create xml-builtin.h to declare xml_builtins
Date: Wed, 16 Oct 2019 14:24:00 -0000 [thread overview]
Message-ID: <20191016142359.473F020AF6@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1570955805000.I806ef0851c43ead90b545a11794e41f5e5178436@gnutoolchain-gerrit.osci.io>
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/25
......................................................................
Patch Set 2: Code-Review+2
> Well xml-builtin.c is created in gdb/ and compiled by both... Do you want me to move both to gdbsupport?
I don't see that in my build. I looked for xml-builtin.o in gdbserver,
and I dug through gdbserver/Makefile.in a bit.
I do see xml-builtin-generated in the Makefile, but that seems to be
a second copy, built locally. It's not made in my build for whatever reason.
Anyway, no, you don't have to change anything. Thanks for doing this.
next prev parent reply other threads:[~2019-10-16 14:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <gerrit.1570955805000.I806ef0851c43ead90b545a11794e41f5e5178436@gnutoolchain-gerrit.osci.io>
2019-10-14 23:10 ` Change in binutils-gdb[master]: " Simon Marchi (Code Review)
2019-10-15 17:30 ` Tom Tromey (Code Review)
2019-10-15 22:34 ` [review] " Christian Biesinger (Code Review)
2019-10-15 22:36 ` Christian Biesinger (Code Review)
2019-10-16 14:24 ` Tom Tromey (Code Review) [this message]
2019-10-16 16:21 ` Sourceware to Gerrit sync (Code Review)
2019-10-16 16:21 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016142359.473F020AF6@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox