From: "Tom Tromey (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Christian Biesinger <cbiesinger@google.com>, gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@polymtl.ca>
Subject: Change in binutils-gdb[master]: Create xml-builtin.h to declare xml_builtins
Date: Tue, 15 Oct 2019 17:30:00 -0000 [thread overview]
Message-ID: <20191015173047.C72C229ECF@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1570955805000.I806ef0851c43ead90b545a11794e41f5e5178436@gnutoolchain-gerrit.osci.io>
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/25
......................................................................
Patch Set 1:
(1 comment)
Thanks for the patch.
I'm not totally sure that the new .h belongs in gdb. On the one hand, I think we want to try to keep gdb and gdbserver separate to some extent, and only share via gdbsupport. On the other hand, I broke that rule already with alloc.c.
I did find a nit though.
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/25/1//COMMIT_MSG
Commit Message:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/25/1//COMMIT_MSG@22
PS1, Line 22: * features/feature_to_c.sh: Add an include for xml-buoltin.h
Typo, should be "xml-builtin.h"
--
To view, visit https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/25
To unsubscribe, or for help writing mail filters, visit https://gnutoolchain-gerrit.osci.io/r/settings
next prev parent reply other threads:[~2019-10-15 17:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <gerrit.1570955805000.I806ef0851c43ead90b545a11794e41f5e5178436@gnutoolchain-gerrit.osci.io>
2019-10-14 23:10 ` Simon Marchi (Code Review)
2019-10-14 23:32 ` Simon Marchi (Code Review)
2019-10-15 17:30 ` Tom Tromey (Code Review) [this message]
2019-10-15 22:34 ` [review] " Christian Biesinger (Code Review)
2019-10-15 22:36 ` Christian Biesinger (Code Review)
2019-10-16 14:24 ` Tom Tromey (Code Review)
2019-10-16 16:21 ` Sourceware to Gerrit sync (Code Review)
2019-10-16 16:21 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015173047.C72C229ECF@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox