Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Christian Biesinger (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Christian Biesinger <cbiesinger@google.com>,	gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@sourceware.org>,
	Simon Marchi <simon.marchi@polymtl.ca>
Subject: [review] Create xml-builtin.h to declare xml_builtins
Date: Tue, 15 Oct 2019 22:36:00 -0000	[thread overview]
Message-ID: <20191015223622.5542726976@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1570955805000.I806ef0851c43ead90b545a11794e41f5e5178436@gnutoolchain-gerrit.osci.io>

Christian Biesinger has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/25
......................................................................


Patch Set 2:

> Patch Set 1:
> 
> (1 comment)
> 
> Thanks for the patch.
> 
> I'm not totally sure that the new .h belongs in gdb.  On the one hand, I think we want to try to keep gdb and gdbserver separate to some extent, and only share via gdbsupport.  On the other hand, I broke that rule already with alloc.c.

Well xml-builtin.c is created in gdb/ and compiled by both... Do you want me to move both to gdbsupport?

> I did find a nit though.

Thanks, fixed.



  parent reply	other threads:[~2019-10-15 22:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <gerrit.1570955805000.I806ef0851c43ead90b545a11794e41f5e5178436@gnutoolchain-gerrit.osci.io>
2019-10-14 23:10 ` Change in binutils-gdb[master]: " Simon Marchi (Code Review)
2019-10-15 17:30 ` Tom Tromey (Code Review)
2019-10-15 22:34 ` [review] " Christian Biesinger (Code Review)
2019-10-15 22:36 ` Christian Biesinger (Code Review) [this message]
2019-10-16 14:24 ` Tom Tromey (Code Review)
2019-10-16 16:21 ` Sourceware to Gerrit sync (Code Review)
2019-10-16 16:21 ` Sourceware to Gerrit sync (Code Review)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191015223622.5542726976@gnutoolchain-gerrit.osci.io \
    --to=gerrit@gnutoolchain-gerrit.osci.io \
    --cc=cbiesinger@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@polymtl.ca \
    --cc=tromey@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox