From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13607 invoked by alias); 15 Oct 2019 17:30:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13598 invoked by uid 89); 15 Oct 2019 17:30:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1030, visit, HContent-Transfer-Encoding:8bit X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 15 Oct 2019 17:30:51 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id DF6412095C; Tue, 15 Oct 2019 13:30:48 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id DC5CB20674; Tue, 15 Oct 2019 13:30:47 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id C72C229ECF; Tue, 15 Oct 2019 13:30:47 -0400 (EDT) X-Gerrit-PatchSet: 1 Date: Tue, 15 Oct 2019 17:30:00 -0000 From: "Tom Tromey (Code Review)" To: Christian Biesinger , gdb-patches@sourceware.org Cc: Simon Marchi Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: Change in binutils-gdb[master]: Create xml-builtin.h to declare xml_builtins X-Gerrit-Change-Id: I806ef0851c43ead90b545a11794e41f5e5178436 X-Gerrit-Change-Number: 25 X-Gerrit-ChangeURL: X-Gerrit-Commit: 1d9acd09343f886e81bb6fcb7ecb6c117ace42d0 In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 15 Oct 2019 13:30:47 -0400 Reply-To: tromey@sourceware.org, simon.marchi@polymtl.ca, cbiesinger@google.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191015173047.C72C229ECF@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg00444.txt.bz2 Tom Tromey has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/25 ...................................................................... Patch Set 1: (1 comment) Thanks for the patch. I'm not totally sure that the new .h belongs in gdb. On the one hand, I think we want to try to keep gdb and gdbserver separate to some extent, and only share via gdbsupport. On the other hand, I broke that rule already with alloc.c. I did find a nit though. https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/25/1//COMMIT_MSG Commit Message: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/25/1//COMMIT_MSG@22 PS1, Line 22: * features/feature_to_c.sh: Add an include for xml-buoltin.h Typo, should be "xml-builtin.h" -- To view, visit https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/25 To unsubscribe, or for help writing mail filters, visit https://gnutoolchain-gerrit.osci.io/r/settings