From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52420 invoked by alias); 16 Oct 2019 14:24:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 52393 invoked by uid 89); 16 Oct 2019 14:24:04 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:717, HContent-Transfer-Encoding:8bit X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 Oct 2019 14:24:02 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 2AA0420926; Wed, 16 Oct 2019 10:24:01 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 5F9AD204E6; Wed, 16 Oct 2019 10:23:59 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 473F020AF6; Wed, 16 Oct 2019 10:23:59 -0400 (EDT) X-Gerrit-PatchSet: 2 Date: Wed, 16 Oct 2019 14:24:00 -0000 From: "Tom Tromey (Code Review)" To: Christian Biesinger , gdb-patches@sourceware.org Cc: Simon Marchi Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Create xml-builtin.h to declare xml_builtins X-Gerrit-Change-Id: I806ef0851c43ead90b545a11794e41f5e5178436 X-Gerrit-Change-Number: 25 X-Gerrit-ChangeURL: X-Gerrit-Commit: 8d926e2b828614bfc7fa1886eacdc0be1714073b In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 16 Oct 2019 10:23:59 -0400 Reply-To: tromey@sourceware.org, simon.marchi@polymtl.ca, cbiesinger@google.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191016142359.473F020AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg00483.txt.bz2 Tom Tromey has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/25 ...................................................................... Patch Set 2: Code-Review+2 > Well xml-builtin.c is created in gdb/ and compiled by both... Do you want me to move both to gdbsupport? I don't see that in my build. I looked for xml-builtin.o in gdbserver, and I dug through gdbserver/Makefile.in a bit. I do see xml-builtin-generated in the Makefile, but that seems to be a second copy, built locally. It's not made in my build for whatever reason. Anyway, no, you don't have to change anything. Thanks for doing this.