From: Joel Brobecker <brobecker@adacore.com>
To: Tom de Vries <tdevries@suse.de>
Cc: Christian Biesinger <cbiesinger@google.com>,
gdb-patches <gdb-patches@sourceware.org>
Subject: Re: GDB 9.1 release: Start of stabilization period ?
Date: Tue, 15 Oct 2019 15:20:00 -0000 [thread overview]
Message-ID: <20191015152012.GB13252@adacore.com> (raw)
In-Reply-To: <9d160e13-fd9e-e886-2709-2a7ea29cae93@suse.de>
> Here's my wishlist:
> - [gdb/tdep] Fix 'Unexpected register class' assert in
> amd64_push_arguments
> https://sourceware.org/ml/gdb-patches/2019-10/msg00293.html
Fixing asserts are always nice to have for releases :-)
> - [gdb/tdep] Fix inferior call arg passing for amd64
> https://sourceware.org/ml/gdb-patches/2019-10/msg00307.html
> - [gdb] Only force INTERP_CONSOLE ui_out for breakpoint commands in MI
> mode
> https://sourceware.org/ml/gdb-patches/2019-10/msg00099.html
> - [gdb/symtab] Prefer var def over decl
> https://sourceware.org/ml/gdb-patches/2019-09/msg00161.html
These look fine in principle as well.
I can't review the patches in detail, but I did noticed on the last
one that you're adding functions without adding documentation for them.
--
Joel
next prev parent reply other threads:[~2019-10-15 15:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-12 19:19 Joel Brobecker
2019-10-13 1:19 ` Christian Biesinger via gdb-patches
2019-10-13 13:58 ` Tom de Vries
2019-10-15 15:20 ` Joel Brobecker [this message]
2019-10-15 15:23 ` Tom de Vries
2019-10-15 15:37 ` Joel Brobecker
2019-10-15 15:16 ` Joel Brobecker
2019-10-13 14:35 ` Philippe Waroquiers
2019-10-15 15:37 ` Joel Brobecker
2019-10-14 17:44 ` Tom Tromey
2019-10-15 15:53 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015152012.GB13252@adacore.com \
--to=brobecker@adacore.com \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox