From: Joel Brobecker <brobecker@adacore.com>
To: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Cc: gdb-patches@sourceware.org
Subject: Re: GDB 9.1 release: Start of stabilization period ?
Date: Tue, 15 Oct 2019 15:37:00 -0000 [thread overview]
Message-ID: <20191015153726.GC13252@adacore.com> (raw)
In-Reply-To: <d2597c391501c2fccc168251a7c6be5b91cf66c6.camel@skynet.be>
Hi Philippe,
Based on the current overall feedback, I think you'll manage to get
if not all, probably some of the changes you propose below.
I'll keep them in my list of items to watch out for, but
see also my comments below:
> Here are the patches sent for review
> (by order of first submission, but pointing at the last exchange):
>
> RFC Have an option to tell GDB to detect and possibly handle mismatched exec-files
> https://sourceware.org/ml/gdb-patches/2019-09/msg00580.html
We can try to keep this one in the list, but I wouldn't mark it
as absolutely critical for the release.
> Convenience functions $_gdb_setting/$_gdb_setting_str
> https://sourceware.org/ml/gdb-patches/2019-09/msg00581.html
Same idea as above, except you are saying that it's ready to push.
Given what we have in the list, and the general proposal, I think
you'll manage to get this one in on time. But I propose we allow
ourselves to skip it if it delays the release process by an unreasonable
amount of time for whatever reason.
> Allow the user to define default leading args for commands and aliases
> https://sourceware.org/ml/gdb-patches/2019-09/msg00583.html
>
> Implement 'print -raw-values' and 'set print raw-values on|off'
> https://sourceware.org/ml/gdb-patches/2019-09/msg00582.html
> More flexible user-defined commands prefixing and naming.
> https://sourceware.org/ml/gdb-patches/2019-09/msg00588.html
These is the kind of change where I think we benefit from not rushing
too much. If it's ready, then great, let's have it. On the other end,
it's really nice to have new features have an "observation period"
in master before they make it to a release. That way, if we discover
some weaknesses while using it in master, we have a chance to adjust
without having to worry about user-compatibility.
The story would be a bit different if you told me that a feature
we just added is severly limited without it, but from what I understand,
this is not the case.
Same here.
> And here is the advocacy to include them ...
>
> The first one fixes an annoying GDB behavior.
>
> I think the second one is now ready to push.
>
> The third and fourth are useful additions or complements
> to the GDB 9.1 'with' and 'option framework' functionalities.
>
> Assuming that with the stabilisation period, there is more review
> bandwidth, then the last one is nice to have :).
>
> Thanks
> Philippe
>
--
Joel
next prev parent reply other threads:[~2019-10-15 15:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-12 19:19 Joel Brobecker
2019-10-13 1:19 ` Christian Biesinger via gdb-patches
2019-10-13 13:58 ` Tom de Vries
2019-10-15 15:20 ` Joel Brobecker
2019-10-15 15:23 ` Tom de Vries
2019-10-15 15:37 ` Joel Brobecker
2019-10-15 15:16 ` Joel Brobecker
2019-10-13 14:35 ` Philippe Waroquiers
2019-10-15 15:37 ` Joel Brobecker [this message]
2019-10-14 17:44 ` Tom Tromey
2019-10-15 15:53 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015153726.GC13252@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=philippe.waroquiers@skynet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox