From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52897 invoked by alias); 15 Oct 2019 15:20:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 52886 invoked by uid 89); 15 Oct 2019 15:20:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:828, msg00293.html, UD:msg00293.html, msg00293html X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 15 Oct 2019 15:20:15 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 1096356085; Tue, 15 Oct 2019 11:20:14 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 4b0yFlld8-gP; Tue, 15 Oct 2019 11:20:14 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id D2CE556083; Tue, 15 Oct 2019 11:20:13 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 41B52838B5; Tue, 15 Oct 2019 08:20:12 -0700 (PDT) Date: Tue, 15 Oct 2019 15:20:00 -0000 From: Joel Brobecker To: Tom de Vries Cc: Christian Biesinger , gdb-patches Subject: Re: GDB 9.1 release: Start of stabilization period ? Message-ID: <20191015152012.GB13252@adacore.com> References: <20191012191938.GA2675@adacore.com> <9d160e13-fd9e-e886-2709-2a7ea29cae93@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9d160e13-fd9e-e886-2709-2a7ea29cae93@suse.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2019-10/txt/msg00423.txt.bz2 > Here's my wishlist: > - [gdb/tdep] Fix 'Unexpected register class' assert in > amd64_push_arguments > https://sourceware.org/ml/gdb-patches/2019-10/msg00293.html Fixing asserts are always nice to have for releases :-) > - [gdb/tdep] Fix inferior call arg passing for amd64 > https://sourceware.org/ml/gdb-patches/2019-10/msg00307.html > - [gdb] Only force INTERP_CONSOLE ui_out for breakpoint commands in MI > mode > https://sourceware.org/ml/gdb-patches/2019-10/msg00099.html > - [gdb/symtab] Prefer var def over decl > https://sourceware.org/ml/gdb-patches/2019-09/msg00161.html These look fine in principle as well. I can't review the patches in detail, but I did noticed on the last one that you're adding functions without adding documentation for them. -- Joel