* Change in binutils-gdb[master]: Create xml-builtin.h to declare xml_builtins
[not found] <gerrit.1570955805000.I806ef0851c43ead90b545a11794e41f5e5178436@gnutoolchain-gerrit.osci.io>
@ 2019-10-14 23:10 ` Simon Marchi (Code Review)
2019-10-14 23:32 ` Simon Marchi (Code Review)
2019-10-15 17:30 ` Tom Tromey (Code Review)
2 siblings, 0 replies; 3+ messages in thread
From: Simon Marchi (Code Review) @ 2019-10-14 23:10 UTC (permalink / raw)
To: Christian Biesinger, gdb-patches
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/25
......................................................................
Patch Set 1:
Hi Christian,
I'm using this change as a test for email notifications formatting.
--
To view, visit https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/25
To unsubscribe, or for help writing mail filters, visit https://gnutoolchain-gerrit.osci.io/r/settings
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I806ef0851c43ead90b545a11794e41f5e5178436
Gerrit-Change-Number: 25
Gerrit-PatchSet: 1
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Mon, 14 Oct 2019 23:10:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
^ permalink raw reply [flat|nested] 3+ messages in thread* Change in binutils-gdb[master]: Create xml-builtin.h to declare xml_builtins
[not found] <gerrit.1570955805000.I806ef0851c43ead90b545a11794e41f5e5178436@gnutoolchain-gerrit.osci.io>
2019-10-14 23:10 ` Change in binutils-gdb[master]: Create xml-builtin.h to declare xml_builtins Simon Marchi (Code Review)
@ 2019-10-14 23:32 ` Simon Marchi (Code Review)
2019-10-15 17:30 ` Tom Tromey (Code Review)
2 siblings, 0 replies; 3+ messages in thread
From: Simon Marchi (Code Review) @ 2019-10-14 23:32 UTC (permalink / raw)
To: Christian Biesinger, gdb-patches
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/25
......................................................................
Patch Set 1:
(1 comment)
Another test.
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/25/1/gdb/features/feature_to_c.sh
File gdb/features/feature_to_c.sh:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/25/1/gdb/features/feature_to_c.sh@35
PS1, Line 35: echo '#include "xml-builtin.h"' >> $output
Hello.
--
To view, visit https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/25
To unsubscribe, or for help writing mail filters, visit https://gnutoolchain-gerrit.osci.io/r/settings
^ permalink raw reply [flat|nested] 3+ messages in thread* Change in binutils-gdb[master]: Create xml-builtin.h to declare xml_builtins
[not found] <gerrit.1570955805000.I806ef0851c43ead90b545a11794e41f5e5178436@gnutoolchain-gerrit.osci.io>
2019-10-14 23:10 ` Change in binutils-gdb[master]: Create xml-builtin.h to declare xml_builtins Simon Marchi (Code Review)
2019-10-14 23:32 ` Simon Marchi (Code Review)
@ 2019-10-15 17:30 ` Tom Tromey (Code Review)
2 siblings, 0 replies; 3+ messages in thread
From: Tom Tromey (Code Review) @ 2019-10-15 17:30 UTC (permalink / raw)
To: Christian Biesinger, gdb-patches; +Cc: Simon Marchi
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/25
......................................................................
Patch Set 1:
(1 comment)
Thanks for the patch.
I'm not totally sure that the new .h belongs in gdb. On the one hand, I think we want to try to keep gdb and gdbserver separate to some extent, and only share via gdbsupport. On the other hand, I broke that rule already with alloc.c.
I did find a nit though.
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/25/1//COMMIT_MSG
Commit Message:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/25/1//COMMIT_MSG@22
PS1, Line 22: * features/feature_to_c.sh: Add an include for xml-buoltin.h
Typo, should be "xml-builtin.h"
--
To view, visit https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/25
To unsubscribe, or for help writing mail filters, visit https://gnutoolchain-gerrit.osci.io/r/settings
^ permalink raw reply [flat|nested] 3+ messages in thread