From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: Tom de Vries <tdevries@suse.de>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFC][gdb/testsuite] Remove breakpoint command in gdb.base/ui-redirect.exp
Date: Wed, 04 Sep 2019 11:57:00 -0000 [thread overview]
Message-ID: <20190904115724.GA14459@host1.jankratochvil.net> (raw)
In-Reply-To: <20190904105952.GI6076@embecosm.com>
On Wed, 04 Sep 2019 12:59:52 +0200, Andrew Burgess wrote:
> I can't comment on the original patch intention, but given this part
> of the tests never really did anything useful, and the "commands"
> mechanism is tested in gdb.base/commands.exp, I'd be OK with what you
> propose below.
The "commands" mechanism is not tested there for "save breakpoints" with
various types of output redirection.
Jan
next prev parent reply other threads:[~2019-09-04 11:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 17:43 Tom de Vries
2019-09-04 10:59 ` Andrew Burgess
2019-09-04 11:57 ` Jan Kratochvil [this message]
2019-09-04 11:49 ` Jan Kratochvil
2019-09-05 7:35 ` [PATCH][gdb/testsuite] Restore breakpoint command in ui-redirect.exp Tom de Vries
2019-09-05 12:03 ` Jan Kratochvil
2019-09-05 12:07 ` Tom de Vries
2019-09-05 12:20 ` Pedro Alves
2019-09-05 12:42 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904115724.GA14459@host1.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox