From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63261 invoked by alias); 4 Sep 2019 11:57:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 63250 invoked by uid 89); 4 Sep 2019 11:57:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Sep 2019 11:57:29 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 852C836887; Wed, 4 Sep 2019 11:57:28 +0000 (UTC) Received: from host1.jankratochvil.net (ovpn-117-1.ams2.redhat.com [10.36.117.1]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7FD9F5FCDF; Wed, 4 Sep 2019 11:57:27 +0000 (UTC) Date: Wed, 04 Sep 2019 11:57:00 -0000 From: Jan Kratochvil To: Andrew Burgess Cc: Tom de Vries , "gdb-patches@sourceware.org" Subject: Re: [RFC][gdb/testsuite] Remove breakpoint command in gdb.base/ui-redirect.exp Message-ID: <20190904115724.GA14459@host1.jankratochvil.net> References: <3150ecd9-9221-4360-6a16-563b3c5ef1ab@suse.de> <20190904105952.GI6076@embecosm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190904105952.GI6076@embecosm.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-SW-Source: 2019-09/txt/msg00028.txt.bz2 On Wed, 04 Sep 2019 12:59:52 +0200, Andrew Burgess wrote: > I can't comment on the original patch intention, but given this part > of the tests never really did anything useful, and the "commands" > mechanism is tested in gdb.base/commands.exp, I'd be OK with what you > propose below. The "commands" mechanism is not tested there for "save breakpoints" with various types of output redirection. Jan