Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	Alan Hayward <alan.hayward@arm.com>,
	Andrew Burgess <andrew.burgess@embecosm.com>
Subject: Re: [PATCH][gdb/testsuite] Restore breakpoint command in ui-redirect.exp
Date: Thu, 05 Sep 2019 12:07:00 -0000	[thread overview]
Message-ID: <4b937f2c-3db9-d9e5-15d8-34f0b9da8de5@suse.de> (raw)
In-Reply-To: <20190905120300.GA1679@host1.jankratochvil.net>

On 05-09-19 14:03, Jan Kratochvil wrote:
> On Thu, 05 Sep 2019 09:34:57 +0200, Tom de Vries wrote:
>> Attached patch fixes the problem by replacing the initial
>> "gdb_breakpoint main" with the runto_main, such that the breakpoint
>> command is preserved throughout.
> 
> Yes, the test is now much better than even was the initial one by me.
> 
> 
>> OK for trunk?
> 
> I cannot approve GDB patches but LGTM.
> 

Thanks. I would at this point commit the patch under the obvious rule,
if it didn't introduce a new proc cmp_file_string in lib/gdb.exp.

Thanks,
- Tom


  reply	other threads:[~2019-09-05 12:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-03 17:43 [RFC][gdb/testsuite] Remove breakpoint command in gdb.base/ui-redirect.exp Tom de Vries
2019-09-04 10:59 ` Andrew Burgess
2019-09-04 11:57   ` Jan Kratochvil
2019-09-04 11:49 ` Jan Kratochvil
2019-09-05  7:35   ` [PATCH][gdb/testsuite] Restore breakpoint command in ui-redirect.exp Tom de Vries
2019-09-05 12:03     ` Jan Kratochvil
2019-09-05 12:07       ` Tom de Vries [this message]
2019-09-05 12:20     ` Pedro Alves
2019-09-05 12:42       ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4b937f2c-3db9-d9e5-15d8-34f0b9da8de5@suse.de \
    --to=tdevries@suse.de \
    --cc=alan.hayward@arm.com \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox