Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Pedro Alves <palves@redhat.com>,
	Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	Alan Hayward <alan.hayward@arm.com>,
	Andrew Burgess <andrew.burgess@embecosm.com>
Subject: Re: [PATCH][gdb/testsuite] Restore breakpoint command in ui-redirect.exp
Date: Thu, 05 Sep 2019 12:42:00 -0000	[thread overview]
Message-ID: <520e8fb4-68d1-d1a0-df96-f2bbc7a2970f@suse.de> (raw)
In-Reply-To: <9e85b162-5b21-9eff-eebb-b51b60194599@redhat.com>

On 05-09-19 14:19, Pedro Alves wrote:
> On 9/5/19 8:34 AM, Tom de Vries wrote:
> 
>> +set cmds \
>> +    [list \
>> +	 "break main" \
>> +	 "  commands" \
>> +	 "    print 1" \
>> +	 "  end" \
>> +	 "break foo" \
>> +	 "break bar"]
>> +set cmds [join $cmds "\n"]
> 
> Use multi_line_input ?
> 
>> +# Compare contents of FILE to string STR. Pass with MSG if equal, otherwise
>> +# fail with MSG.
> 
> Double space after period.
> 

Thanks for the review.

Committed with these two review remarks fixed.

Thanks,
- Tom


      reply	other threads:[~2019-09-05 12:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-03 17:43 [RFC][gdb/testsuite] Remove breakpoint command in gdb.base/ui-redirect.exp Tom de Vries
2019-09-04 10:59 ` Andrew Burgess
2019-09-04 11:57   ` Jan Kratochvil
2019-09-04 11:49 ` Jan Kratochvil
2019-09-05  7:35   ` [PATCH][gdb/testsuite] Restore breakpoint command in ui-redirect.exp Tom de Vries
2019-09-05 12:03     ` Jan Kratochvil
2019-09-05 12:07       ` Tom de Vries
2019-09-05 12:20     ` Pedro Alves
2019-09-05 12:42       ` Tom de Vries [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=520e8fb4-68d1-d1a0-df96-f2bbc7a2970f@suse.de \
    --to=tdevries@suse.de \
    --cc=alan.hayward@arm.com \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox