From: Kevin Buettner <kevinb@redhat.com>
To: Simon Marchi <simark@simark.ca>
Cc: gdb-patches@sourceware.org, Eli Zaretskii <eliz@gnu.org>
Subject: Re: The 'cold' function attribute and GDB
Date: Thu, 02 May 2019 02:51:00 -0000 [thread overview]
Message-ID: <20190501195113.69aea752@f30-4.lan> (raw)
In-Reply-To: <077aee8c-7bef-bad6-a6a1-e69f116cc18b@simark.ca>
On Wed, 1 May 2019 16:17:04 -0400
Simon Marchi <simark@simark.ca> wrote:
> In an ideal world, if gcc generates two separate ranges
> of instruction for this function (the hot path and the cold path), it should describe
> it as two ranges in the entry for print_vectorlike. If so, it should be described with
> a DW_AT_ranges attribute.
Yes, this is exactly right.
[...]
> Also, which commit of GDB is this with? I recall some patches related to non-contiguous
> address ranges not too long ago.
As I recall, I committed the non-contiguous address range stuff in
late August of 2018. It might be the case that 8.3 will be the first
release to include that support. Any build based on a commit to
master since 2018-08-24 should have this support.
I think I need to write some small programs which use the 'cold'
attribute to see what the DWARF looks like. I was unaware of this
attribute prior to reading Eli's message on this matter. If it can
be avoided, I (too) would prefer to not add a special case for handling
cold minimal symbols.
Kevin
next prev parent reply other threads:[~2019-05-02 2:51 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 18:59 Eli Zaretskii
2019-05-01 20:17 ` Simon Marchi
2019-05-02 2:51 ` Kevin Buettner [this message]
2019-05-02 6:59 ` Eli Zaretskii
2019-05-02 7:26 ` Kevin Buettner
2019-05-02 15:27 ` Eli Zaretskii
2019-05-02 15:59 ` Kevin Buettner
2019-05-02 16:46 ` Eli Zaretskii
2019-05-02 18:08 ` Simon Marchi
2019-05-02 18:47 ` Eli Zaretskii
2019-05-02 18:55 ` Kevin Buettner
2019-05-02 19:32 ` Eli Zaretskii
2019-05-02 19:51 ` Kevin Buettner
2019-05-02 7:06 ` Eli Zaretskii
2019-05-02 7:38 ` Kevin Buettner
2019-05-02 15:23 ` Eli Zaretskii
2019-05-02 15:56 ` Kevin Buettner
2019-05-02 16:43 ` Eli Zaretskii
2019-05-02 18:25 ` Kevin Buettner
2019-05-02 18:52 ` Eli Zaretskii
2019-05-02 19:13 ` Kevin Buettner
2019-05-02 19:28 ` Eli Zaretskii
2019-05-02 19:45 ` Kevin Buettner
2019-05-02 19:56 ` Eli Zaretskii
2019-05-02 23:30 ` Kevin Buettner
2019-05-04 8:30 ` Eli Zaretskii
2019-05-05 20:04 ` Kevin Buettner
2019-05-06 15:33 ` Eli Zaretskii
2019-05-06 16:24 ` Kevin Buettner
2019-05-02 15:17 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190501195113.69aea752@f30-4.lan \
--to=kevinb@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox