Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Kevin Buettner <kevinb@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org, Simon Marchi <simark@simark.ca>
Subject: Re: The 'cold' function attribute and GDB
Date: Thu, 02 May 2019 07:26:00 -0000	[thread overview]
Message-ID: <20190502002644.5e40b489@f29-4.lan> (raw)
In-Reply-To: <D5F8A46A-F181-434B-89C5-0C2AB5397B28@gnu.org>

On Thu, 02 May 2019 09:58:47 +0300
Eli Zaretskii <eliz@gnu.org> wrote:

> On May 2, 2019 5:51:13 AM GMT+03:00, Kevin Buettner <kevinb@redhat.com> wrote:
> > On Wed, 1 May 2019 16:17:04 -0400
> > Simon Marchi <simark@simark.ca> wrote:  
> 
> > > Also, which commit of GDB is this with?  I recall some patches  
> > related to non-contiguous  
> > > address ranges not too long ago.  
> > 
> > As I recall, I committed the non-contiguous address range stuff in
> > late August of 2018.  It might be the case that 8.3 will be the first
> > release to include that support.  Any build based on a commit to
> > master since 2018-08-24 should have this support.  
> 
> The non-contiguous address ranges support seems to target
> specifically the disassembly command?  This does display 2 separate
> address ranges, both in GDB 8.2 and in the latest pretest of 8.3. 
> But were those changes supposed to teach backtrace and stack frame
> reporting in general about multiple ranges?  Because in that case
> GDB needs to solve the inverse problem:  go from the address to the
> symbol.

There were four distinct problems that my non-contiguous address range
patch set addressed.  As you say, one of them was disassembly of
functions with discontiguous ranges.  But that work also addressed
problems with stepping, with breakpoint placement, and with display of
addresses.  A brief discussion of these matters can be found here:

https://www.sourceware.org/ml/gdb-patches/2018-08/msg00541.html

It's possible that more needs to be done with display of addresses. 
I'll need to look at it more closely to know for sure.  It would help
me if there were a relatively small test case to look at.  (It would
help even more if it could be reproduced on a GNU/Linux system.)

Kevin


  reply	other threads:[~2019-05-02  7:26 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-01 18:59 Eli Zaretskii
2019-05-01 20:17 ` Simon Marchi
2019-05-02  2:51   ` Kevin Buettner
2019-05-02  6:59     ` Eli Zaretskii
2019-05-02  7:26       ` Kevin Buettner [this message]
2019-05-02 15:27         ` Eli Zaretskii
2019-05-02 15:59           ` Kevin Buettner
2019-05-02 16:46             ` Eli Zaretskii
2019-05-02 18:08               ` Simon Marchi
2019-05-02 18:47                 ` Eli Zaretskii
2019-05-02 18:55                   ` Kevin Buettner
2019-05-02 19:32                     ` Eli Zaretskii
2019-05-02 19:51                       ` Kevin Buettner
2019-05-02  7:06     ` Eli Zaretskii
2019-05-02  7:38       ` Kevin Buettner
2019-05-02 15:23         ` Eli Zaretskii
2019-05-02 15:56           ` Kevin Buettner
2019-05-02 16:43             ` Eli Zaretskii
2019-05-02 18:25           ` Kevin Buettner
2019-05-02 18:52             ` Eli Zaretskii
2019-05-02 19:13               ` Kevin Buettner
2019-05-02 19:28                 ` Eli Zaretskii
2019-05-02 19:45                   ` Kevin Buettner
2019-05-02 19:56                     ` Eli Zaretskii
2019-05-02 23:30                       ` Kevin Buettner
2019-05-04  8:30                         ` Eli Zaretskii
2019-05-05 20:04                           ` Kevin Buettner
2019-05-06 15:33                             ` Eli Zaretskii
2019-05-06 16:24                               ` Kevin Buettner
2019-05-02 15:17       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190502002644.5e40b489@f29-4.lan \
    --to=kevinb@redhat.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox