From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13817 invoked by alias); 2 May 2019 02:51:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13808 invoked by uid 89); 2 May 2019 02:51:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=August, august, H*M:lan X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 02 May 2019 02:51:16 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BABBE308213F; Thu, 2 May 2019 02:51:14 +0000 (UTC) Received: from f30-4.lan (ovpn-116-84.phx2.redhat.com [10.3.116.84]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7842C7B8C5; Thu, 2 May 2019 02:51:14 +0000 (UTC) Date: Thu, 02 May 2019 02:51:00 -0000 From: Kevin Buettner To: Simon Marchi Cc: gdb-patches@sourceware.org, Eli Zaretskii Subject: Re: The 'cold' function attribute and GDB Message-ID: <20190501195113.69aea752@f30-4.lan> In-Reply-To: <077aee8c-7bef-bad6-a6a1-e69f116cc18b@simark.ca> References: <83wojaovbp.fsf@gnu.org> <077aee8c-7bef-bad6-a6a1-e69f116cc18b@simark.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-05/txt/msg00023.txt.bz2 On Wed, 1 May 2019 16:17:04 -0400 Simon Marchi wrote: > In an ideal world, if gcc generates two separate ranges > of instruction for this function (the hot path and the cold path), it should describe > it as two ranges in the entry for print_vectorlike. If so, it should be described with > a DW_AT_ranges attribute. Yes, this is exactly right. [...] > Also, which commit of GDB is this with? I recall some patches related to non-contiguous > address ranges not too long ago. As I recall, I committed the non-contiguous address range stuff in late August of 2018. It might be the case that 8.3 will be the first release to include that support. Any build based on a commit to master since 2018-08-24 should have this support. I think I need to write some small programs which use the 'cold' attribute to see what the DWARF looks like. I was unaware of this attribute prior to reading Eli's message on this matter. If it can be avoided, I (too) would prefer to not add a special case for handling cold minimal symbols. Kevin