* [PATCH] sim: Fix build for avr simulator
@ 2019-03-28 18:06 Dimitar Dimitrov
2019-03-28 21:28 ` Andrew Burgess
0 siblings, 1 reply; 4+ messages in thread
From: Dimitar Dimitrov @ 2019-03-28 18:06 UTC (permalink / raw)
To: gdb-patches; +Cc: Dimitar Dimitrov
This commit:
commit ef9866970ce6683d40465fb7c3168f87a1dcd1b7
Date: Thu Mar 28 06:40:30 2019 +0900
sim/common: convert sim-arange to use sim-inline
Broke simulator build for AVR.
sim/avr/ChangeLog:
2019-03-28 Dimitar Dimitrov <dimitar@dinux.eu>
* interp.c: Include sim-assert.h
Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
---
sim/avr/interp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sim/avr/interp.c b/sim/avr/interp.c
index 973409225a..46f0270961 100644
--- a/sim/avr/interp.c
+++ b/sim/avr/interp.c
@@ -27,6 +27,7 @@
#include "gdb/remote-sim.h"
#include "sim-main.h"
+#include "sim-assert.h"
#include "sim-base.h"
#include "sim-options.h"
--
2.11.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] sim: Fix build for avr simulator
2019-03-28 18:06 [PATCH] sim: Fix build for avr simulator Dimitar Dimitrov
@ 2019-03-28 21:28 ` Andrew Burgess
2019-03-28 21:35 ` Simon Marchi
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Burgess @ 2019-03-28 21:28 UTC (permalink / raw)
To: Dimitar Dimitrov; +Cc: gdb-patches
* Dimitar Dimitrov <dimitar@dinux.eu> [2019-03-28 20:05:43 +0200]:
> This commit:
>
> commit ef9866970ce6683d40465fb7c3168f87a1dcd1b7
> Date: Thu Mar 28 06:40:30 2019 +0900
>
> sim/common: convert sim-arange to use sim-inline
>
> Broke simulator build for AVR.
>
> sim/avr/ChangeLog:
>
> 2019-03-28 Dimitar Dimitrov <dimitar@dinux.eu>
>
> * interp.c: Include sim-assert.h
>
> Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
This is fine.
Thanks,
Andrew
> ---
> sim/avr/interp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sim/avr/interp.c b/sim/avr/interp.c
> index 973409225a..46f0270961 100644
> --- a/sim/avr/interp.c
> +++ b/sim/avr/interp.c
> @@ -27,6 +27,7 @@
> #include "gdb/remote-sim.h"
>
> #include "sim-main.h"
> +#include "sim-assert.h"
> #include "sim-base.h"
> #include "sim-options.h"
>
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sim: Fix build for avr simulator
2019-03-28 21:28 ` Andrew Burgess
@ 2019-03-28 21:35 ` Simon Marchi
2019-03-28 22:39 ` Andrew Burgess
0 siblings, 1 reply; 4+ messages in thread
From: Simon Marchi @ 2019-03-28 21:35 UTC (permalink / raw)
To: Andrew Burgess; +Cc: Dimitar Dimitrov, gdb-patches
On 2019-03-28 17:28, Andrew Burgess wrote:
> * Dimitar Dimitrov <dimitar@dinux.eu> [2019-03-28 20:05:43 +0200]:
>
>> This commit:
>>
>> commit ef9866970ce6683d40465fb7c3168f87a1dcd1b7
>> Date: Thu Mar 28 06:40:30 2019 +0900
>>
>> sim/common: convert sim-arange to use sim-inline
>>
>> Broke simulator build for AVR.
>>
>> sim/avr/ChangeLog:
>>
>> 2019-03-28 Dimitar Dimitrov <dimitar@dinux.eu>
>>
>> * interp.c: Include sim-assert.h
>>
>> Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
>
> This is fine.
>
> Thanks,
> Andrew
I believe that Dimitar doesn't have push access to GDB, so you should
probably push the patch on his behalf.
Simon
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sim: Fix build for avr simulator
2019-03-28 21:35 ` Simon Marchi
@ 2019-03-28 22:39 ` Andrew Burgess
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Burgess @ 2019-03-28 22:39 UTC (permalink / raw)
To: Simon Marchi; +Cc: Dimitar Dimitrov, gdb-patches
* Simon Marchi <simon.marchi@polymtl.ca> [2019-03-28 17:35:32 -0400]:
> On 2019-03-28 17:28, Andrew Burgess wrote:
> > * Dimitar Dimitrov <dimitar@dinux.eu> [2019-03-28 20:05:43 +0200]:
> >
> > > This commit:
> > >
> > > commit ef9866970ce6683d40465fb7c3168f87a1dcd1b7
> > > Date: Thu Mar 28 06:40:30 2019 +0900
> > >
> > > sim/common: convert sim-arange to use sim-inline
> > >
> > > Broke simulator build for AVR.
> > >
> > > sim/avr/ChangeLog:
> > >
> > > 2019-03-28 Dimitar Dimitrov <dimitar@dinux.eu>
> > >
> > > * interp.c: Include sim-assert.h
> > >
> > > Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
> >
> > This is fine.
> >
> > Thanks,
> > Andrew
>
> I believe that Dimitar doesn't have push access to GDB, so you should
> probably push the patch on his behalf.
Thanks for pointing this out.
I've just been investigating and it turns out many other sim targets
were broken by commit ef9866970ce... I think a more general fix is
required, I'll post one soon.
Thanks,
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-28 22:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-28 18:06 [PATCH] sim: Fix build for avr simulator Dimitar Dimitrov
2019-03-28 21:28 ` Andrew Burgess
2019-03-28 21:35 ` Simon Marchi
2019-03-28 22:39 ` Andrew Burgess
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox