From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104035 invoked by alias); 28 Mar 2019 22:39:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 103999 invoked by uid 89); 28 Mar 2019 22:39:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-13.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1039, his X-HELO: mail-wr1-f66.google.com Received: from mail-wr1-f66.google.com (HELO mail-wr1-f66.google.com) (209.85.221.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 Mar 2019 22:39:20 +0000 Received: by mail-wr1-f66.google.com with SMTP id k17so199071wrx.10 for ; Thu, 28 Mar 2019 15:39:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=xCMMUGw2xfPc9HKsJXF+2y9r5TASpK0cqNLKnfLtN2U=; b=Td4H/W9SVeup7toteQXvIdddRnZKtpmzmAPIEGcgudttGx6SpEJ+5xUbKo9U17lp4v fBVbVlhF0x9f/vlYRMjji2wllK4tDjYDGvofj0GCdX7eRt8CG1O888bcq4wWG0tEvXxg wXJkZ1r5OPt54vop6LLKuJJPZJcGoFUR0MS1oADP8DXXaG6mtfY7Ymf9iWnOoBBK6mjo vB+eEtzvt8WonExJfeAELWPAawbquVCQcH9RuuK8weU7SOFg6/24W2CHa5Yq78O/7OBa FOrJ/aaUMnwaQCLRq2OhXP67lF+BPq5YRFZ5v5QY/bj6Mkta1ssE241uTVFokmjBhBLx xf6Q== Return-Path: Received: from localhost (host81-151-161-58.range81-151.btcentralplus.com. [81.151.161.58]) by smtp.gmail.com with ESMTPSA id a8sm326972wmf.33.2019.03.28.15.39.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Mar 2019 15:39:17 -0700 (PDT) Date: Thu, 28 Mar 2019 22:39:00 -0000 From: Andrew Burgess To: Simon Marchi Cc: Dimitar Dimitrov , gdb-patches@sourceware.org Subject: Re: [PATCH] sim: Fix build for avr simulator Message-ID: <20190328223915.GF10887@embecosm.com> References: <20190328180543.9358-1-dimitar@dinux.eu> <20190328212846.GD10887@embecosm.com> <26d4e3e797d26aa8a59eb399062e5ce4@polymtl.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <26d4e3e797d26aa8a59eb399062e5ce4@polymtl.ca> X-Fortune: Maintence window broken X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00733.txt.bz2 * Simon Marchi [2019-03-28 17:35:32 -0400]: > On 2019-03-28 17:28, Andrew Burgess wrote: > > * Dimitar Dimitrov [2019-03-28 20:05:43 +0200]: > > > > > This commit: > > > > > > commit ef9866970ce6683d40465fb7c3168f87a1dcd1b7 > > > Date: Thu Mar 28 06:40:30 2019 +0900 > > > > > > sim/common: convert sim-arange to use sim-inline > > > > > > Broke simulator build for AVR. > > > > > > sim/avr/ChangeLog: > > > > > > 2019-03-28 Dimitar Dimitrov > > > > > > * interp.c: Include sim-assert.h > > > > > > Signed-off-by: Dimitar Dimitrov > > > > This is fine. > > > > Thanks, > > Andrew > > I believe that Dimitar doesn't have push access to GDB, so you should > probably push the patch on his behalf. Thanks for pointing this out. I've just been investigating and it turns out many other sim targets were broken by commit ef9866970ce... I think a more general fix is required, I'll post one soon. Thanks, Andrew