Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Burgess <andrew.burgess@embecosm.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Dimitar Dimitrov <dimitar@dinux.eu>, gdb-patches@sourceware.org
Subject: Re: [PATCH] sim: Fix build for avr simulator
Date: Thu, 28 Mar 2019 22:39:00 -0000	[thread overview]
Message-ID: <20190328223915.GF10887@embecosm.com> (raw)
In-Reply-To: <26d4e3e797d26aa8a59eb399062e5ce4@polymtl.ca>

* Simon Marchi <simon.marchi@polymtl.ca> [2019-03-28 17:35:32 -0400]:

> On 2019-03-28 17:28, Andrew Burgess wrote:
> > * Dimitar Dimitrov <dimitar@dinux.eu> [2019-03-28 20:05:43 +0200]:
> > 
> > > This commit:
> > > 
> > >   commit ef9866970ce6683d40465fb7c3168f87a1dcd1b7
> > >   Date:   Thu Mar 28 06:40:30 2019 +0900
> > > 
> > >       sim/common: convert sim-arange to use sim-inline
> > > 
> > > Broke simulator build for AVR.
> > > 
> > > sim/avr/ChangeLog:
> > > 
> > > 2019-03-28  Dimitar Dimitrov  <dimitar@dinux.eu>
> > > 
> > >         * interp.c: Include sim-assert.h
> > > 
> > > Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
> > 
> > This is fine.
> > 
> > Thanks,
> > Andrew
> 
> I believe that Dimitar doesn't have push access to GDB, so you should
> probably push the patch on his behalf.

Thanks for pointing this out.

I've just been investigating and it turns out many other sim targets
were broken by commit ef9866970ce... I think a more general fix is
required, I'll post one soon.

Thanks,
Andrew


      reply	other threads:[~2019-03-28 22:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-28 18:06 Dimitar Dimitrov
2019-03-28 21:28 ` Andrew Burgess
2019-03-28 21:35   ` Simon Marchi
2019-03-28 22:39     ` Andrew Burgess [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190328223915.GF10887@embecosm.com \
    --to=andrew.burgess@embecosm.com \
    --cc=dimitar@dinux.eu \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox