Re: [PATCH] RISC-V: Add osabi support.

[Andrew Burgess <andrew.burgess@embecosm.com>]

* John Baldwin <jhb@FreeBSD.org> [2018-07-05 15:25:54 -0700]:

> On 7/4/18 2:11 AM, Andrew Burgess wrote:
> > * Jim Wilson <jimw@sifive.com> [2018-07-03 17:15:18 -0700]:
> > 
> >> This adds the osabi init call that the linux native port needs.
> >>
> >> 	gdb/
> >> 	* riscv-tdep.c (riscv_gdbarch_init): Call gdbarch_init_osabi.
> > 
> > I'm happy with this patch, but again wonder if this should be part of
> > a sequence that adds OS support?
> 
> I would be happy to have these bits go in actually as I will probably start
> working on FreeBSD RISC-V support in the near future (albeit using
> QEMU as my test environment for now).  Having the riscv-tdep.c changes
> upstream will make that easier rather than either duplicating that work
> or having to temporarily pull it into my own branches.

In terms of the code content of this patch (and the other one I
commented on) I'm perfectly happy.

However, I don't feel I'm qualified to give the OK to merge these
given the original push back against merging unused code.  I'd rather
a global maintainer say yes or no.

Thanks,
Andrew


> 
> -- 
> John Baldwin