From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34192 invoked by alias); 6 Jul 2018 21:39:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 34166 invoked by uid 89); 6 Jul 2018 21:39:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-wr1-f67.google.com Received: from mail-wr1-f67.google.com (HELO mail-wr1-f67.google.com) (209.85.221.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Jul 2018 21:39:55 +0000 Received: by mail-wr1-f67.google.com with SMTP id j33-v6so5386934wrj.5 for ; Fri, 06 Jul 2018 14:39:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=vjoqmR96dC7T43CGqeILSm25XyKrK8abnk2frJIs3DA=; b=Wmq2T1FCItX3UturdmVDzMr76Nafld5OBc/+PUcjkE2g6WGIjCw43pvckXgjxUTgDE VolPCJFLhGWIA1nogiSA7027ysQQqbRoJRel2f/QNSlFe705hPtROSxIKdEw6f+70cw1 7+pKdaPmTeMmFkx6sae0BL0paTyPFfkw8p5bul9lmGRohxfpPgRw46YRi8om8uTJ70T0 y1zqEgSIklwoLpQegt/dMqk7MPYSJxvtJeSYAn/ADSFCkOL1193HF1T5DTWqtFwu0sgi rOqEX/2U435TMpdk16ETUHC/GnQzQax+sTcBK4/eOB0mo/A/cGUrGUUPkrT3SU+7MGhZ UmEw== Return-Path: Received: from localhost (host86-164-199-62.range86-164.btcentralplus.com. [86.164.199.62]) by smtp.gmail.com with ESMTPSA id 189-v6sm19309148wmy.25.2018.07.06.14.39.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 06 Jul 2018 14:39:52 -0700 (PDT) Date: Fri, 06 Jul 2018 21:39:00 -0000 From: Andrew Burgess To: John Baldwin Cc: Jim Wilson , gdb-patches@sourceware.org Subject: Re: [PATCH] RISC-V: Add osabi support. Message-ID: <20180706213950.GO2675@embecosm.com> References: <20180704001518.27593-1-jimw@sifive.com> <20180704091106.GF2675@embecosm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Fortune: Suicide is simply a case of mistaken identity. X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg00155.txt.bz2 * John Baldwin [2018-07-05 15:25:54 -0700]: > On 7/4/18 2:11 AM, Andrew Burgess wrote: > > * Jim Wilson [2018-07-03 17:15:18 -0700]: > > > >> This adds the osabi init call that the linux native port needs. > >> > >> gdb/ > >> * riscv-tdep.c (riscv_gdbarch_init): Call gdbarch_init_osabi. > > > > I'm happy with this patch, but again wonder if this should be part of > > a sequence that adds OS support? > > I would be happy to have these bits go in actually as I will probably start > working on FreeBSD RISC-V support in the near future (albeit using > QEMU as my test environment for now). Having the riscv-tdep.c changes > upstream will make that easier rather than either duplicating that work > or having to temporarily pull it into my own branches. In terms of the code content of this patch (and the other one I commented on) I'm perfectly happy. However, I don't feel I'm qualified to give the OK to merge these given the original push back against merging unused code. I'd rather a global maintainer say yes or no. Thanks, Andrew > > -- > John Baldwin