Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Burgess <andrew.burgess@embecosm.com>
To: Jim Wilson <jimw@sifive.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] RISC-V: Add osabi support.
Date: Wed, 04 Jul 2018 09:11:00 -0000	[thread overview]
Message-ID: <20180704091106.GF2675@embecosm.com> (raw)
In-Reply-To: <20180704001518.27593-1-jimw@sifive.com>

* Jim Wilson <jimw@sifive.com> [2018-07-03 17:15:18 -0700]:

> This adds the osabi init call that the linux native port needs.
> 
> 	gdb/
> 	* riscv-tdep.c (riscv_gdbarch_init): Call gdbarch_init_osabi.

I'm happy with this patch, but again wonder if this should be part of
a sequence that adds OS support?

Thanks,
Andrewx

> ---
>  gdb/riscv-tdep.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/gdb/riscv-tdep.c b/gdb/riscv-tdep.c
> index 154567136e..1b941eee55 100644
> --- a/gdb/riscv-tdep.c
> +++ b/gdb/riscv-tdep.c
> @@ -2562,6 +2562,9 @@ riscv_gdbarch_init (struct gdbarch_info info,
>      user_reg_add (gdbarch, riscv_register_aliases[i].name,
>  		  value_of_riscv_user_reg, &riscv_register_aliases[i].regnum);
>  
> +  /* Hook in OS ABI-specific overrides, if they have been registered.  */
> +  gdbarch_init_osabi (info, gdbarch);
> +
>    return gdbarch;
>  }
>  
> -- 
> 2.17.1
> 


  reply	other threads:[~2018-07-04  9:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-04  0:16 Jim Wilson
2018-07-04  9:11 ` Andrew Burgess [this message]
2018-07-05 22:26   ` John Baldwin
2018-07-06 21:39     ` Andrew Burgess
2018-07-07  1:53       ` Simon Marchi
2018-07-16 21:51         ` Jim Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180704091106.GF2675@embecosm.com \
    --to=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jimw@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox