From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28882 invoked by alias); 4 Jul 2018 09:11:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27933 invoked by uid 89); 4 Jul 2018 09:11:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:921 X-HELO: mail-wr0-f194.google.com Received: from mail-wr0-f194.google.com (HELO mail-wr0-f194.google.com) (209.85.128.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Jul 2018 09:11:09 +0000 Received: by mail-wr0-f194.google.com with SMTP id u7-v6so4531474wrn.12 for ; Wed, 04 Jul 2018 02:11:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=oNOedLO+O1M4xEDhNgmisRrOf7kWYTq8tT9ejTJjotQ=; b=ftsvY7S8qA0dgcHNbYpuz7PQpkX8WgOztb3TEbRsJklCoHd6XcS6ZGrmqftGLievbV gg6MSI6cs0zz8zYhiBMr1otKf+xQrbc497gkB9iR4BTH5sY9+Ja//l3l5H6z5/TCJWpU 0Pnjaq2EwqsHDGVZNuESrxsnTist/5lNYR7QJE1YV0FyOG+epPLKSNSlDWaK4McWPwz3 e4H5w+k2PT6nzJMKKb4f0PSMO2/Z3q7DdVYvCi/Ip976Lgc5vMnOVUkE3mUGat7+UAWP RBCIqnnD0WDYggWHq3xFvQnZWvQG9uv6g803Hh9jMUiyoj4capp64us2QRNfqlqV2MTJ XcSg== Return-Path: Received: from localhost (host81-140-212-80.range81-140.btcentralplus.com. [81.140.212.80]) by smtp.gmail.com with ESMTPSA id k18-v6sm1077659wrn.61.2018.07.04.02.11.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 04 Jul 2018 02:11:06 -0700 (PDT) Date: Wed, 04 Jul 2018 09:11:00 -0000 From: Andrew Burgess To: Jim Wilson Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] RISC-V: Add osabi support. Message-ID: <20180704091106.GF2675@embecosm.com> References: <20180704001518.27593-1-jimw@sifive.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180704001518.27593-1-jimw@sifive.com> X-Fortune: If you wish to succeed, consult three old people. X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg00077.txt.bz2 * Jim Wilson [2018-07-03 17:15:18 -0700]: > This adds the osabi init call that the linux native port needs. > > gdb/ > * riscv-tdep.c (riscv_gdbarch_init): Call gdbarch_init_osabi. I'm happy with this patch, but again wonder if this should be part of a sequence that adds OS support? Thanks, Andrewx > --- > gdb/riscv-tdep.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/gdb/riscv-tdep.c b/gdb/riscv-tdep.c > index 154567136e..1b941eee55 100644 > --- a/gdb/riscv-tdep.c > +++ b/gdb/riscv-tdep.c > @@ -2562,6 +2562,9 @@ riscv_gdbarch_init (struct gdbarch_info info, > user_reg_add (gdbarch, riscv_register_aliases[i].name, > value_of_riscv_user_reg, &riscv_register_aliases[i].regnum); > > + /* Hook in OS ABI-specific overrides, if they have been registered. */ > + gdbarch_init_osabi (info, gdbarch); > + > return gdbarch; > } > > -- > 2.17.1 >