Re: [PATCH] RISC-V: Add osabi support.

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2018-07-06 17:39, Andrew Burgess wrote:
> * John Baldwin <jhb@FreeBSD.org> [2018-07-05 15:25:54 -0700]:
> 
>> On 7/4/18 2:11 AM, Andrew Burgess wrote:
>> > * Jim Wilson <jimw@sifive.com> [2018-07-03 17:15:18 -0700]:
>> >
>> >> This adds the osabi init call that the linux native port needs.
>> >>
>> >> 	gdb/
>> >> 	* riscv-tdep.c (riscv_gdbarch_init): Call gdbarch_init_osabi.
>> >
>> > I'm happy with this patch, but again wonder if this should be part of
>> > a sequence that adds OS support?
>> 
>> I would be happy to have these bits go in actually as I will probably 
>> start
>> working on FreeBSD RISC-V support in the near future (albeit using
>> QEMU as my test environment for now).  Having the riscv-tdep.c changes
>> upstream will make that easier rather than either duplicating that 
>> work
>> or having to temporarily pull it into my own branches.
> 
> In terms of the code content of this patch (and the other one I
> commented on) I'm perfectly happy.
> 
> However, I don't feel I'm qualified to give the OK to merge these
> given the original push back against merging unused code.  I'd rather
> a global maintainer say yes or no.

I think this is fine.  That line is kind of standard boilerplate in 
gdbarch_init methods.  The <arch>-tdep.c file is not really supposed to 
know what osabi variants exist above it, so it's ok to call it "just in 
case".  It's not like we are adding one thousand lines of not-yet-used 
code :).

Simon