From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52804 invoked by alias); 7 Jul 2018 01:53:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 52620 invoked by uid 89); 7 Jul 2018 01:53:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1480, thousand X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 07 Jul 2018 01:53:49 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w671rgSc022311 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 6 Jul 2018 21:53:47 -0400 Received: by simark.ca (Postfix, from userid 112) id A68221EF2A; Fri, 6 Jul 2018 21:53:42 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 808631E08D; Fri, 6 Jul 2018 21:53:39 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 07 Jul 2018 01:53:00 -0000 From: Simon Marchi To: Andrew Burgess Cc: John Baldwin , Jim Wilson , gdb-patches@sourceware.org Subject: Re: [PATCH] RISC-V: Add osabi support. In-Reply-To: <20180706213950.GO2675@embecosm.com> References: <20180704001518.27593-1-jimw@sifive.com> <20180704091106.GF2675@embecosm.com> <20180706213950.GO2675@embecosm.com> Message-ID: <16706857fdc1be2a14e982b3a57eaf99@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg00159.txt.bz2 On 2018-07-06 17:39, Andrew Burgess wrote: > * John Baldwin [2018-07-05 15:25:54 -0700]: > >> On 7/4/18 2:11 AM, Andrew Burgess wrote: >> > * Jim Wilson [2018-07-03 17:15:18 -0700]: >> > >> >> This adds the osabi init call that the linux native port needs. >> >> >> >> gdb/ >> >> * riscv-tdep.c (riscv_gdbarch_init): Call gdbarch_init_osabi. >> > >> > I'm happy with this patch, but again wonder if this should be part of >> > a sequence that adds OS support? >> >> I would be happy to have these bits go in actually as I will probably >> start >> working on FreeBSD RISC-V support in the near future (albeit using >> QEMU as my test environment for now). Having the riscv-tdep.c changes >> upstream will make that easier rather than either duplicating that >> work >> or having to temporarily pull it into my own branches. > > In terms of the code content of this patch (and the other one I > commented on) I'm perfectly happy. > > However, I don't feel I'm qualified to give the OK to merge these > given the original push back against merging unused code. I'd rather > a global maintainer say yes or no. I think this is fine. That line is kind of standard boilerplate in gdbarch_init methods. The -tdep.c file is not really supposed to know what osabi variants exist above it, so it's ok to call it "just in case". It's not like we are adding one thousand lines of not-yet-used code :). Simon