From: Philipp Rudo <prudo@linux.vnet.ibm.com>
To: gdb-patches@sourceware.org
Cc: arnez@linux.vnet.ibm.com
Subject: [PATCH 08/11] Remove unused deprecated_{attach|detach}_hook
Date: Tue, 28 Feb 2017 14:50:00 -0000 [thread overview]
Message-ID: <20170228145016.22604-9-prudo@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170228145016.22604-1-prudo@linux.vnet.ibm.com>
Nobody actually uses these hooks anymore. So simply remove them.
gdb/ChangeLog
* defs.h (deprecated_attach_hook, deprecated_detach_hook): Remove.
* top.c (deprecated_attach_hook, deprecated_detach_hook): Remove.
* infcmd.c (attach_post_wait, detach_command)
(disconnect_command): Adjust.
* target.c (generic_mourn_inferior): Adjust.
---
gdb/defs.h | 2 --
gdb/infcmd.c | 7 -------
gdb/target.c | 3 ---
gdb/top.c | 6 ------
4 files changed, 18 deletions(-)
diff --git a/gdb/defs.h b/gdb/defs.h
index 3c97825..a52db88 100644
--- a/gdb/defs.h
+++ b/gdb/defs.h
@@ -672,8 +672,6 @@ extern void (*deprecated_print_frame_info_listing_hook) (struct symtab * s,
int noerror);
extern int (*deprecated_query_hook) (const char *, va_list)
ATTRIBUTE_FPTR_PRINTF(1,0);
-extern void (*deprecated_attach_hook) (void);
-extern void (*deprecated_detach_hook) (void);
extern void (*deprecated_call_command_hook) (struct cmd_list_element * c,
char *cmd, int from_tty);
diff --git a/gdb/infcmd.c b/gdb/infcmd.c
index d836162..93d8c3e 100644
--- a/gdb/infcmd.c
+++ b/gdb/infcmd.c
@@ -2752,8 +2752,6 @@ attach_post_wait (char *args, int from_tty, enum attach_post_wait_mode mode)
/* Tell the user/frontend where we're stopped. */
normal_stop ();
- if (deprecated_attach_hook)
- deprecated_attach_hook ();
}
}
@@ -3008,9 +3006,6 @@ detach_command (char *args, int from_tty)
threads. */
if (!have_inferiors ())
init_thread_list ();
-
- if (deprecated_detach_hook)
- deprecated_detach_hook ();
}
/* Disconnect from the current target without resuming it (leaving it
@@ -3030,8 +3025,6 @@ disconnect_command (char *args, int from_tty)
target_disconnect (args, from_tty);
no_shared_libraries (NULL, from_tty);
init_thread_list ();
- if (deprecated_detach_hook)
- deprecated_detach_hook ();
}
void
diff --git a/gdb/target.c b/gdb/target.c
index 0ff8515..3820fb7 100644
--- a/gdb/target.c
+++ b/gdb/target.c
@@ -3336,9 +3336,6 @@ generic_mourn_inferior (void)
reopen_exec_file ();
reinit_frame_cache ();
-
- if (deprecated_detach_hook)
- deprecated_detach_hook ();
}
\f
/* Convert a normal process ID to a string. Returns the string in a
diff --git a/gdb/top.c b/gdb/top.c
index 0ddef13..e33caf4 100644
--- a/gdb/top.c
+++ b/gdb/top.c
@@ -194,12 +194,6 @@ void (*deprecated_print_frame_info_listing_hook) (struct symtab * s,
int (*deprecated_query_hook) (const char *, va_list);
-/* Called as appropriate to notify the interface that we have attached
- to or detached from an already running process. */
-
-void (*deprecated_attach_hook) (void);
-void (*deprecated_detach_hook) (void);
-
/* Used by UI as a wrapper around command execution. May do various
things like enabling/disabling buttons, etc... */
--
2.8.4
next prev parent reply other threads:[~2017-02-28 14:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 14:50 [PATCH 00/11] Cleanup deprecated_*_hooks in defs.h Philipp Rudo
2017-02-28 14:50 ` [PATCH 05/11] Remove unused deprecated_readline{_begin|_end}_hook Philipp Rudo
2017-02-28 14:50 ` [PATCH 09/11] Remove unused deprecated_call_command_hook Philipp Rudo
2017-02-28 14:50 ` [PATCH 02/11] Remove unused deprecated_ui_loop_hook Philipp Rudo
2017-02-28 14:50 ` [PATCH 01/11] Remove unused deprecated_{pre|post}_add_symbol_hook Philipp Rudo
2017-02-28 14:50 ` [PATCH 03/11] Remove unused deprecated_warning_hook Philipp Rudo
2017-02-28 14:50 ` [PATCH 10/11] Remove unused deprecated_ui_load_progress_hook Philipp Rudo
2017-02-28 14:50 ` [PATCH 11/11] Remove deprecated_print_frame_info_listing_hook Philipp Rudo
2017-02-28 14:50 ` Philipp Rudo [this message]
2017-02-28 14:50 ` [PATCH 06/11] Remove unused deprecated_context_hook Philipp Rudo
2017-02-28 15:28 ` [PATCH 00/11] Cleanup deprecated_*_hooks in defs.h Tom Tromey
2017-02-28 15:52 ` Simon Marchi
2017-03-01 9:11 ` Philipp Rudo
2017-03-01 22:17 ` Yao Qi
2017-02-28 18:01 ` [PATCH 04/11] Remove unused deprecated_interactive_hook Philipp Rudo
2017-02-28 19:37 ` [PATCH 00/11] Cleanup deprecated_*_hooks in defs.h Keith Seitz
2017-02-28 19:45 ` [PATCH 07/11] Remove unused deprecated_target_wait_hook Philipp Rudo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170228145016.22604-9-prudo@linux.vnet.ibm.com \
--to=prudo@linux.vnet.ibm.com \
--cc=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox