Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Philipp Rudo <prudo@linux.vnet.ibm.com>
To: gdb-patches@sourceware.org
Cc: arnez@linux.vnet.ibm.com
Subject: [PATCH 01/11] Remove unused deprecated_{pre|post}_add_symbol_hook
Date: Tue, 28 Feb 2017 14:50:00 -0000	[thread overview]
Message-ID: <20170228145016.22604-2-prudo@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170228145016.22604-1-prudo@linux.vnet.ibm.com>

Nobody actually uses those hooks anymore. So simply remove them.

gdb/ChangeLog

	* defs.h (deprecated_pre_add_symbol_hook)
	(deprecated_post_add_symbol_hook): Remove.
	* symfile.c (deprecated_pre_add_symbol_hook)
	(deprecated_post_add_symbol_hook): Remove.
	(symbol_file_add_with_addrs): Adjust.
---
 gdb/defs.h    |  2 --
 gdb/symfile.c | 18 ++++--------------
 2 files changed, 4 insertions(+), 16 deletions(-)

diff --git a/gdb/defs.h b/gdb/defs.h
index aa58605..b3086b9 100644
--- a/gdb/defs.h
+++ b/gdb/defs.h
@@ -660,8 +660,6 @@ extern char *interpreter_p;
 struct target_waitstatus;
 struct cmd_list_element;
 
-extern void (*deprecated_pre_add_symbol_hook) (const char *);
-extern void (*deprecated_post_add_symbol_hook) (void);
 extern void (*selected_frame_level_changed_hook) (int);
 extern int (*deprecated_ui_loop_hook) (int signo);
 extern void (*deprecated_show_load_progress) (const char *section,
diff --git a/gdb/symfile.c b/gdb/symfile.c
index f2528fc..a749a2c 100644
--- a/gdb/symfile.c
+++ b/gdb/symfile.c
@@ -72,8 +72,6 @@ void (*deprecated_show_load_progress) (const char *section,
 			    unsigned long section_size,
 			    unsigned long total_sent,
 			    unsigned long total_size);
-void (*deprecated_pre_add_symbol_hook) (const char *);
-void (*deprecated_post_add_symbol_hook) (void);
 
 static void clear_symtab_users_cleanup (void *ignore);
 
@@ -1174,14 +1172,9 @@ symbol_file_add_with_addrs (bfd *abfd, const char *name,
      performed, or need to read an unmapped symbol table.  */
   if (should_print)
     {
-      if (deprecated_pre_add_symbol_hook)
-	deprecated_pre_add_symbol_hook (name);
-      else
-	{
-	  printf_unfiltered (_("Reading symbols from %s..."), name);
-	  wrap_here ("");
-	  gdb_flush (gdb_stdout);
-	}
+      printf_unfiltered (_("Reading symbols from %s..."), name);
+      wrap_here ("");
+      gdb_flush (gdb_stdout);
     }
   syms_from_objfile (objfile, addrs, add_flags);
 
@@ -1212,10 +1205,7 @@ symbol_file_add_with_addrs (bfd *abfd, const char *name,
 
   if (should_print)
     {
-      if (deprecated_post_add_symbol_hook)
-	deprecated_post_add_symbol_hook ();
-      else
-	printf_unfiltered (_("done.\n"));
+      printf_unfiltered (_("done.\n"));
     }
 
   /* We print some messages regardless of whether 'from_tty ||
-- 
2.8.4


  parent reply	other threads:[~2017-02-28 14:50 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-28 14:50 [PATCH 00/11] Cleanup deprecated_*_hooks in defs.h Philipp Rudo
2017-02-28 14:50 ` [PATCH 05/11] Remove unused deprecated_readline{_begin|_end}_hook Philipp Rudo
2017-02-28 14:50 ` Philipp Rudo [this message]
2017-02-28 14:50 ` [PATCH 09/11] Remove unused deprecated_call_command_hook Philipp Rudo
2017-02-28 14:50 ` [PATCH 02/11] Remove unused deprecated_ui_loop_hook Philipp Rudo
2017-02-28 14:50 ` [PATCH 03/11] Remove unused deprecated_warning_hook Philipp Rudo
2017-02-28 14:50 ` [PATCH 10/11] Remove unused deprecated_ui_load_progress_hook Philipp Rudo
2017-02-28 14:50 ` [PATCH 08/11] Remove unused deprecated_{attach|detach}_hook Philipp Rudo
2017-02-28 14:50 ` [PATCH 06/11] Remove unused deprecated_context_hook Philipp Rudo
2017-02-28 14:50 ` [PATCH 11/11] Remove deprecated_print_frame_info_listing_hook Philipp Rudo
2017-02-28 15:28 ` [PATCH 00/11] Cleanup deprecated_*_hooks in defs.h Tom Tromey
2017-02-28 15:52   ` Simon Marchi
2017-03-01  9:11     ` Philipp Rudo
2017-03-01 22:17       ` Yao Qi
2017-02-28 18:01 ` [PATCH 04/11] Remove unused deprecated_interactive_hook Philipp Rudo
2017-02-28 19:37 ` [PATCH 00/11] Cleanup deprecated_*_hooks in defs.h Keith Seitz
2017-02-28 19:45 ` [PATCH 07/11] Remove unused deprecated_target_wait_hook Philipp Rudo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170228145016.22604-2-prudo@linux.vnet.ibm.com \
    --to=prudo@linux.vnet.ibm.com \
    --cc=arnez@linux.vnet.ibm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox