From: Mike Frysinger <vapier@gentoo.org>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: binutils@sourceware.org, gdb-patches@sourceware.org
Subject: Re: Require GNU make to build binutils-gdb
Date: Thu, 17 Nov 2016 20:06:00 -0000 [thread overview]
Message-ID: <20161117200637.GV21655@vapier.lan> (raw)
In-Reply-To: <144f4f68acf24fc1084b585700c65b63@polymtl.ca>
[-- Attachment #1: Type: text/plain, Size: 1820 bytes --]
On 17 Nov 2016 14:11, Simon Marchi wrote:
> In gdb/, we are now making use of GNU make-specific features (in
> particular, pattern rules), so we now require building with GNU make.
> We based our decision on the fact that, for every platform on which we
> are aware people build GDB on, GNU make is easily available. In fact,
> according to the echoes we got, people already use gmake to build gdb
> everywhere.
>
> Pedro determined that GNU make 3.81 was practically universally
> available:
>
> https://sourceware.org/ml/gdb-patches/2016-11/msg00475.html
>
> Additionally, CentOS 6 (so probably RHEL6 as well) and Ubuntu 14.04 have
> 3.81 in their repos. Just those two probably represent a significant
> user base. So, unless we have a really good reason to require something
> more recent, I think it makes sense to require GNU make >= 3.81.
>
> For simplicity and consistency, we were wondering if we should adopt the
> same policy for the whole binutils-gdb tree. While not necessary, it
> opens up the door to using GNU make-specific constructs in other
> Makefiles in the tree, possibly improving readability and
> maintainability. This change in GDB gives a good idea:
>
> http://tinyurl.com/hb8ozrz
>
> There was a discussion in 2014 that spun off another thread. Nobody
> seemed against the idea, but there was no follow-up AFAICT:
>
> https://sourceware.org/ml/binutils/2014-05/msg00263.html
>
> In the eventuality this proposition is accepted, should we have a check
> in the top-level Makefile that warns the user early if their version of
> make is not supported?
seems like it should be adopted by gcc first ?
for sim/, i have no problem having it follow gdb, although i was planning
on converting it to automake ...
-mike
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-11-17 20:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 19:11 Simon Marchi
2016-11-17 20:06 ` Mike Frysinger [this message]
2016-11-17 20:33 ` Simon Marchi
2016-11-17 20:43 ` Paul Smith
2016-11-17 21:14 ` Simon Marchi
2016-11-17 20:39 ` Andreas Schwab
2016-11-18 10:33 ` Nick Clifton
2016-11-18 13:00 ` Simon Marchi
2016-11-18 17:04 ` Nick Clifton
2016-11-19 3:04 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161117200637.GV21655@vapier.lan \
--to=vapier@gentoo.org \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox