From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111732 invoked by alias); 17 Nov 2016 20:06:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 111700 invoked by uid 89); 17 Nov 2016 20:06:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=centos, 201405, 2014-05, opens X-Spam-User: qpsmtpd, 2 recipients X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 17 Nov 2016 20:06:39 +0000 Received: from vapier.lan (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id D250A3412F9; Thu, 17 Nov 2016 20:06:37 +0000 (UTC) Date: Thu, 17 Nov 2016 20:06:00 -0000 From: Mike Frysinger To: Simon Marchi Cc: binutils@sourceware.org, gdb-patches@sourceware.org Subject: Re: Require GNU make to build binutils-gdb Message-ID: <20161117200637.GV21655@vapier.lan> Mail-Followup-To: Simon Marchi , binutils@sourceware.org, gdb-patches@sourceware.org References: <144f4f68acf24fc1084b585700c65b63@polymtl.ca> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="i4WgBwpUkbQcesZD" Content-Disposition: inline In-Reply-To: <144f4f68acf24fc1084b585700c65b63@polymtl.ca> X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00496.txt.bz2 --i4WgBwpUkbQcesZD Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1840 On 17 Nov 2016 14:11, Simon Marchi wrote: > In gdb/, we are now making use of GNU make-specific features (in=20 > particular, pattern rules), so we now require building with GNU make.=20= =20 > We based our decision on the fact that, for every platform on which we=20 > are aware people build GDB on, GNU make is easily available. In fact,=20 > according to the echoes we got, people already use gmake to build gdb=20 > everywhere. >=20 > Pedro determined that GNU make 3.81 was practically universally=20 > available: >=20 > https://sourceware.org/ml/gdb-patches/2016-11/msg00475.html >=20 > Additionally, CentOS 6 (so probably RHEL6 as well) and Ubuntu 14.04 have= =20 > 3.81 in their repos. Just those two probably represent a significant=20 > user base. So, unless we have a really good reason to require something= =20 > more recent, I think it makes sense to require GNU make >=3D 3.81. >=20 > For simplicity and consistency, we were wondering if we should adopt the= =20 > same policy for the whole binutils-gdb tree. While not necessary, it=20 > opens up the door to using GNU make-specific constructs in other=20 > Makefiles in the tree, possibly improving readability and=20 > maintainability. This change in GDB gives a good idea: >=20 > http://tinyurl.com/hb8ozrz >=20 > There was a discussion in 2014 that spun off another thread. Nobody=20 > seemed against the idea, but there was no follow-up AFAICT: >=20 > https://sourceware.org/ml/binutils/2014-05/msg00263.html >=20 > In the eventuality this proposition is accepted, should we have a check=20 > in the top-level Makefile that warns the user early if their version of=20 > make is not supported? seems like it should be adopted by gcc first ? for sim/, i have no problem having it follow gdb, although i was planning on converting it to automake ... -mike --i4WgBwpUkbQcesZD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYLg3NAAoJEEFjO5/oN/WBFLkP/R6UQgiehkt8mUlF6BDnUsq+ FF9U/98YXL6FHSTTmdC21SfcXYffjQjjINLLCfJS3AosmFCk+Meix1v5bCFKLh1f Jb/NhBTUcZuszi4sMCE9ifLSBR3F8rpA0To3TVIb2h1EUMWn1IG5tLcjEScDi5+Q vxHbBddCqVZ5DqUR04EunKJC2iz9ZLtAwek5GUkUk6Lji9oEopfPlc1Rj9GKFv7T cfU980z8tDAc9lHQIDVLqex0pRSfm+vyLFebhXT+eQZBu036GIG+MUDWtgdUTLbG ckyW46D9GDT0vvqQgcx69K3aR+50W8JeXgW4d5KB3sn5htMCe4wmp15RXb01UIXx zR9mKJuhHGL7FhMwEJN+6u78Z1QMMWEEghb4QW3Mk+M+YGQ8C0cco4XkxsEtS9dy K13agaN+MfejGmkCq7WT6+ZN1V0laV7vXBwHoRYRv0d0k5NE7CHaxrec3ai3SFs9 r7drsX7G5CmQBYEWw1XOAa5Wbn5dTP4Euv33XJE0/AV7zr7KoYhwVRz6iBV7FmfG EiyX0bt2l4T3Hqvwcowluqhp7GI/zXy1AxpORljBzoprwf213bCVtDRL9+qI2Gn3 GCtjx+nbe97FOmmBlS3Y6b362Uebzns7GNFAA/aydh7cidJFv+mz22akrfSnvMFs +AiYmFw9nKtdmzPFc6z1 =XKl2 -----END PGP SIGNATURE----- --i4WgBwpUkbQcesZD--