Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: psmith@gnu.org
Cc: binutils@sourceware.org, gdb-patches@sourceware.org
Subject: Re: Require GNU make to build binutils-gdb
Date: Thu, 17 Nov 2016 21:14:00 -0000	[thread overview]
Message-ID: <b8e4c5e07a0c9cdbf8bfb26564f61a78@polymtl.ca> (raw)
In-Reply-To: <1479415358.3489.313.camel@gnu.org>

On 2016-11-17 15:42, Paul Smith wrote:
> Regarding the patch linked to earlier, I wonder why multiple pattern
> rules were added, rather than just using VPATH plus a few pattern rules
> / explicit rules for the special cases?
> 
> I didn't check carefully.

Are you talking about gdb/Makefile.in?  Could you be more specific?  I 
am not a Makefile expert, so if there's a better way to do what I did, 
I'd like to learn about it.

> If you want to check for 3.81, you could look for the .FEATURES 
> variable
> instead of .VARIABLES; .FEATURES was introduced in 3.81 and is intended
> to let your makefile query what features are available without worrying
> about specific versions.
> 
> It's also never empty, if it exists.  It has one nice advantage in that
> it's a static value, while .VARIABLES requires GNU make to create a 
> list
> of the names of all the variables.  But, if this check is done early
> that's not such a big deal.
> 
> 3.81 was released 10.5 years ago (Apr 2006).

Thanks for the tip.  I found the original gcc patch that added the 3.80 
checking code, it also mentions .FEATURES for checking for 3.81:

   https://gcc.gnu.org/ml/gcc-patches/2008-04/msg01018.html

> automake, technically, generates POSIX compliant makefiles that don't
> rely on GNU make features at all and should work with a wide range of
> different make implementations.
> 
> At least, that's how it is unless something has changed since I looked
> last.

I think you're right. Skimming the automake manual, I saw some mentions 
of tricks you could use if you assumed GNU make would be used.  So in 
the best case, requiring GNU make unlocks some features we could not 
have used otherwise, and worst case it doesn't change anything.


  reply	other threads:[~2016-11-17 21:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-17 19:11 Simon Marchi
2016-11-17 20:06 ` Mike Frysinger
2016-11-17 20:33   ` Simon Marchi
2016-11-17 20:43     ` Paul Smith
2016-11-17 21:14       ` Simon Marchi [this message]
2016-11-17 20:39   ` Andreas Schwab
2016-11-18 10:33 ` Nick Clifton
2016-11-18 13:00   ` Simon Marchi
2016-11-18 17:04     ` Nick Clifton
2016-11-19  3:04       ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8e4c5e07a0c9cdbf8bfb26564f61a78@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=binutils@sourceware.org \
    --cc=gdb-patches@sourceware.org \
    --cc=psmith@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox