Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: binutils@sourceware.org, gdb-patches@sourceware.org
Subject: Re: Require GNU make to build binutils-gdb
Date: Thu, 17 Nov 2016 20:33:00 -0000	[thread overview]
Message-ID: <d9cb5139cd8d41d27464716b2f135e9c@polymtl.ca> (raw)
In-Reply-To: <20161117200637.GV21655@vapier.lan>

On 2016-11-17 15:06, Mike Frysinger wrote:
>> In the eventuality this proposition is accepted, should we have a 
>> check
>> in the top-level Makefile that warns the user early if their version 
>> of
>> make is not supported?
> 
> seems like it should be adopted by gcc first ?

I am not sure how the management of the top-level files work, so I'll 
let others respond.

But as Andreas Schwab mentioned in our earlier discussions, there is 
already such a check for gcc:

   @if gcc
   ifeq (,$(.VARIABLES)) # The variable .VARIABLES, new with 3.80, is 
never empty.
   $(error GNU make version 3.80 or newer is required.)
   endif
   @endif gcc

Since we don't have a particular reason to want 3.81 over 3.80, we could 
just re-use this check (make it unconditional), if that makes it easier.

> for sim/, i have no problem having it follow gdb, although i was 
> planning
> on converting it to automake ...

I think that's a good thing then, automake probably plays better with 
GNU make than other makes.


  reply	other threads:[~2016-11-17 20:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-17 19:11 Simon Marchi
2016-11-17 20:06 ` Mike Frysinger
2016-11-17 20:33   ` Simon Marchi [this message]
2016-11-17 20:43     ` Paul Smith
2016-11-17 21:14       ` Simon Marchi
2016-11-17 20:39   ` Andreas Schwab
2016-11-18 10:33 ` Nick Clifton
2016-11-18 13:00   ` Simon Marchi
2016-11-18 17:04     ` Nick Clifton
2016-11-19  3:04       ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9cb5139cd8d41d27464716b2f135e9c@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=binutils@sourceware.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox