[obv] [testsuite] i386-biarch-core.exp: Fix comment typo

[obv] [testsuite] i386-biarch-core.exp: Fix comment typo

[Jan Kratochvil]

[-- Attachment #1: Type: text/plain, Size: 0 bytes --]



[-- Attachment #2: Type: message/rfc822, Size: 1838 bytes --]

From: Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: [PATCH] i386-biarch-core.exp: Fix comment typo
Date: Tue, 14 Jul 2015 19:50:20 +0200

gdb/testsuite/ChangeLog
2015-07-14  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* gdb.arch/i386-biarch-core.exp: Fix comment typo.
---
 gdb/testsuite/ChangeLog                     | 4 ++++
 gdb/testsuite/gdb.arch/i386-biarch-core.exp | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 47c1e9b..5e8b930 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2015-07-14  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+	* gdb.arch/i386-biarch-core.exp: Fix comment typo.
+
 2015-07-14  Pedro Alves  <palves@redhat.com>
 
 	* gdb.base/killed-outside.exp: New file.
diff --git a/gdb/testsuite/gdb.arch/i386-biarch-core.exp b/gdb/testsuite/gdb.arch/i386-biarch-core.exp
index 612b4d8..60d049b 100644
--- a/gdb/testsuite/gdb.arch/i386-biarch-core.exp
+++ b/gdb/testsuite/gdb.arch/i386-biarch-core.exp
@@ -50,7 +50,7 @@ gdb_reinitialize_dir $srcdir/$subdir
 # Wrongly built GDB complains by:
 # "..." is not a core dump: File format not recognized
 # As the provided test core has 64bit PRSTATUS i386 built GDB cannot parse it.
-# This is just a problem of the test care, real-world elf64-i386 file will have
+# This is just a problem of the test case, real-world elf64-i386 file will have
 # 32bit PRSTATUS.  One cannot prepare elf64-i386 core file from elf32-i386 by
 # objcopy as it corrupts the core file beyond all recognition.
 gdb_test "core-file ${corefile}" "\r\nwarning: Unexpected size of section `\\.reg/6901' in core file\\.\r\n.*Core was generated by `\[^\r\n\]*'\\.\r\nProgram terminated with signal SIGSEGV, Segmentation fault\\.\r\n.*" "core-file"
-- 
2.1.0

Re: [obv] [testsuite] i386-biarch-core.exp: Fix comment typo

[Luis Machado]

On 07/14/2015 02:51 PM, Jan Kratochvil wrote:
>
> ForwardedMessage.eml
>
> Subject:
> [PATCH] i386-biarch-core.exp: Fix comment typo
> From:
> Jan Kratochvil <jan.kratochvil@redhat.com>
> Date:
> 07/14/2015 02:50 PM
>
>
> gdb/testsuite/ChangeLog
> 2015-07-14  Jan Kratochvil<jan.kratochvil@redhat.com>
>
> 	* gdb.arch/i386-biarch-core.exp: Fix comment typo.
> ---
>   gdb/testsuite/ChangeLog                     | 4 ++++
>   gdb/testsuite/gdb.arch/i386-biarch-core.exp | 2 +-
>   2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
> index 47c1e9b..5e8b930 100644
> --- a/gdb/testsuite/ChangeLog
> +++ b/gdb/testsuite/ChangeLog
> @@ -1,3 +1,7 @@
> +2015-07-14  Jan Kratochvil<jan.kratochvil@redhat.com>
> +
> +	* gdb.arch/i386-biarch-core.exp: Fix comment typo.
> +
>   2015-07-14  Pedro Alves<palves@redhat.com>
>
>   	* gdb.base/killed-outside.exp: New file.
> diff --git a/gdb/testsuite/gdb.arch/i386-biarch-core.exp b/gdb/testsuite/gdb.arch/i386-biarch-core.exp
> index 612b4d8..60d049b 100644
> --- a/gdb/testsuite/gdb.arch/i386-biarch-core.exp
> +++ b/gdb/testsuite/gdb.arch/i386-biarch-core.exp
> @@ -50,7 +50,7 @@ gdb_reinitialize_dir $srcdir/$subdir
>   # Wrongly built GDB complains by:
>   # "..." is not a core dump: File format not recognized
>   # As the provided test core has 64bit PRSTATUS i386 built GDB cannot parse it.
> -# This is just a problem of the test care, real-world elf64-i386 file will have
> +# This is just a problem of the test case, real-world elf64-i386 file will have
>   # 32bit PRSTATUS.  One cannot prepare elf64-i386 core file from elf32-i386 by
>   # objcopy as it corrupts the core file beyond all recognition.
>   gdb_test "core-file ${corefile}" "\r\nwarning: Unexpected size of section `\\.reg/6901' in core file\\.\r\n.*Core was generated by `\[^\r\n\]*'\\.\r\nProgram terminated with signal SIGSEGV, Segmentation fault\\.\r\n.*" "core-file"
> -- 2.1.0
>

I noticed this test is running for MIPS (and probably other non-i386 
targets). Was it really your intention to have this test execute on 
non-i386 targets?

Re: [obv] [testsuite] i386-biarch-core.exp: Fix comment typo

[Jan Kratochvil]

On Tue, 15 Sep 2015 16:03:18 +0200, Luis Machado wrote:
> I noticed this test is running for MIPS (and probably other non-i386
> targets). Was it really your intention to have this test execute on non-i386
> targets?

Yes, it was the intention (not in every configuration - depending on what
secondary targets are supported on that host).

We were discussing it in the thread:
	https://sourceware.org/ml/gdb-patches/2015-07/msg00389.html

I have verified now that on ppc64-rhel-7.1 it PASSes.  I do not have MIPS
handy, though.  Could you at least post your MIPS gdb.log?


Thanks,
Jan

Re: [obv] [testsuite] i386-biarch-core.exp: Fix comment typo

[Luis Machado]

On 09/15/2015 11:22 AM, Jan Kratochvil wrote:
> On Tue, 15 Sep 2015 16:03:18 +0200, Luis Machado wrote:
>> I noticed this test is running for MIPS (and probably other non-i386
>> targets). Was it really your intention to have this test execute on non-i386
>> targets?
>
> Yes, it was the intention (not in every configuration - depending on what
> secondary targets are supported on that host).
>
> We were discussing it in the thread:
> 	https://sourceware.org/ml/gdb-patches/2015-07/msg00389.html
>
> I have verified now that on ppc64-rhel-7.1 it PASSes.  I do not have MIPS
> handy, though.  Could you at least post your MIPS gdb.log?

I'm seeing this:

core-file gdb.arch/i386-biarch-core.core
gdb/mips-tdep.c:1098: internal-error: bad register size
A problem internal to GDB has been detected,
further debugging may prove unreliable.^
Quit this debugging session? (y or n)
FAIL: gdb.arch/i386-biarch-core.exp: core-file (GDB internal error)

Re: [obv] [testsuite] i386-biarch-core.exp: Fix comment typo

[Luis Machado]

On 09/15/2015 11:29 AM, Luis Machado wrote:
> On 09/15/2015 11:22 AM, Jan Kratochvil wrote:
>> On Tue, 15 Sep 2015 16:03:18 +0200, Luis Machado wrote:
>>> I noticed this test is running for MIPS (and probably other non-i386
>>> targets). Was it really your intention to have this test execute on
>>> non-i386
>>> targets?
>>
>> Yes, it was the intention (not in every configuration - depending on what
>> secondary targets are supported on that host).
>>
>> We were discussing it in the thread:
>>     https://sourceware.org/ml/gdb-patches/2015-07/msg00389.html
>>
>> I have verified now that on ppc64-rhel-7.1 it PASSes.  I do not have MIPS
>> handy, though.  Could you at least post your MIPS gdb.log?
>
> I'm seeing this:
>
> core-file gdb.arch/i386-biarch-core.core
> gdb/mips-tdep.c:1098: internal-error: bad register size
> A problem internal to GDB has been detected,
> further debugging may prove unreliable.^
> Quit this debugging session? (y or n)
> FAIL: gdb.arch/i386-biarch-core.exp: core-file (GDB internal error)
>

The lines are a bit off, but basically we end up hitting the internal 
error at mips-tdep.c:mips_pseudo_register_read. I don't think the MIPS 
backend is currently crafted to handle reading unknown register blocks.

Re: [obv] [testsuite] i386-biarch-core.exp: Fix comment typo

[Jan Kratochvil]

On Tue, 15 Sep 2015 16:35:28 +0200, Luis Machado wrote:
> On 09/15/2015 11:29 AM, Luis Machado wrote:
> >core-file gdb.arch/i386-biarch-core.core
> >gdb/mips-tdep.c:1098: internal-error: bad register size
> >A problem internal to GDB has been detected,
> >further debugging may prove unreliable.^
> >Quit this debugging session? (y or n)
> >FAIL: gdb.arch/i386-biarch-core.exp: core-file (GDB internal error)
> 
> The lines are a bit off, but basically we end up hitting the internal error
> at mips-tdep.c:mips_pseudo_register_read. I don't think the MIPS backend is
> currently crafted to handle reading unknown register blocks.

Then it is a mips-tdep.c bug similar to this i386-tdep.c bug:
	https://sourceware.org/bugzilla/show_bug.cgi?id=17808

In general GDB should not crash when you let it read an arbitrary file.

If you want I can file it as a new MIPS-specific PR and KFAIL it.


Jan

Re: [obv] [testsuite] i386-biarch-core.exp: Fix comment typo

[Luis Machado]

On 09/15/2015 11:37 AM, Jan Kratochvil wrote:
> On Tue, 15 Sep 2015 16:35:28 +0200, Luis Machado wrote:
>> On 09/15/2015 11:29 AM, Luis Machado wrote:
>>> core-file gdb.arch/i386-biarch-core.core
>>> gdb/mips-tdep.c:1098: internal-error: bad register size
>>> A problem internal to GDB has been detected,
>>> further debugging may prove unreliable.^
>>> Quit this debugging session? (y or n)
>>> FAIL: gdb.arch/i386-biarch-core.exp: core-file (GDB internal error)
>>
>> The lines are a bit off, but basically we end up hitting the internal error
>> at mips-tdep.c:mips_pseudo_register_read. I don't think the MIPS backend is
>> currently crafted to handle reading unknown register blocks.
>
> Then it is a mips-tdep.c bug similar to this i386-tdep.c bug:
> 	https://sourceware.org/bugzilla/show_bug.cgi?id=17808
>
> In general GDB should not crash when you let it read an arbitrary file.
>
> If you want I can file it as a new MIPS-specific PR and KFAIL it.

Yes, thanks. That would be helpful. No need to KFAIL it though. It 
should be fixed soon.

Re: [obv] [testsuite] i386-biarch-core.exp: Fix comment typo

[Jan Kratochvil]

On Tue, 15 Sep 2015 16:51:16 +0200, Luis Machado wrote:
> On 09/15/2015 11:37 AM, Jan Kratochvil wrote:
> >Then it is a mips-tdep.c bug similar to this i386-tdep.c bug:
> >	https://sourceware.org/bugzilla/show_bug.cgi?id=17808
> >
> >In general GDB should not crash when you let it read an arbitrary file.
> >
> >If you want I can file it as a new MIPS-specific PR and KFAIL it.
> 
> Yes, thanks. That would be helpful. No need to KFAIL it though. It should be
> fixed soon.

[mips] 7.9 regression: internal-error: mips-tdep.c:1098: bad register size
https://sourceware.org/bugzilla/show_bug.cgi?id=18964