Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Luis Machado <lgustavo@codesourcery.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [obv] [testsuite] i386-biarch-core.exp: Fix comment typo
Date: Tue, 15 Sep 2015 14:03:00 -0000	[thread overview]
Message-ID: <55F82526.4020709@codesourcery.com> (raw)
In-Reply-To: <20150714175127.GA10807@host1.jankratochvil.net>

On 07/14/2015 02:51 PM, Jan Kratochvil wrote:
>
> ForwardedMessage.eml
>
> Subject:
> [PATCH] i386-biarch-core.exp: Fix comment typo
> From:
> Jan Kratochvil <jan.kratochvil@redhat.com>
> Date:
> 07/14/2015 02:50 PM
>
>
> gdb/testsuite/ChangeLog
> 2015-07-14  Jan Kratochvil<jan.kratochvil@redhat.com>
>
> 	* gdb.arch/i386-biarch-core.exp: Fix comment typo.
> ---
>   gdb/testsuite/ChangeLog                     | 4 ++++
>   gdb/testsuite/gdb.arch/i386-biarch-core.exp | 2 +-
>   2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
> index 47c1e9b..5e8b930 100644
> --- a/gdb/testsuite/ChangeLog
> +++ b/gdb/testsuite/ChangeLog
> @@ -1,3 +1,7 @@
> +2015-07-14  Jan Kratochvil<jan.kratochvil@redhat.com>
> +
> +	* gdb.arch/i386-biarch-core.exp: Fix comment typo.
> +
>   2015-07-14  Pedro Alves<palves@redhat.com>
>
>   	* gdb.base/killed-outside.exp: New file.
> diff --git a/gdb/testsuite/gdb.arch/i386-biarch-core.exp b/gdb/testsuite/gdb.arch/i386-biarch-core.exp
> index 612b4d8..60d049b 100644
> --- a/gdb/testsuite/gdb.arch/i386-biarch-core.exp
> +++ b/gdb/testsuite/gdb.arch/i386-biarch-core.exp
> @@ -50,7 +50,7 @@ gdb_reinitialize_dir $srcdir/$subdir
>   # Wrongly built GDB complains by:
>   # "..." is not a core dump: File format not recognized
>   # As the provided test core has 64bit PRSTATUS i386 built GDB cannot parse it.
> -# This is just a problem of the test care, real-world elf64-i386 file will have
> +# This is just a problem of the test case, real-world elf64-i386 file will have
>   # 32bit PRSTATUS.  One cannot prepare elf64-i386 core file from elf32-i386 by
>   # objcopy as it corrupts the core file beyond all recognition.
>   gdb_test "core-file ${corefile}" "\r\nwarning: Unexpected size of section `\\.reg/6901' in core file\\.\r\n.*Core was generated by `\[^\r\n\]*'\\.\r\nProgram terminated with signal SIGSEGV, Segmentation fault\\.\r\n.*" "core-file"
> -- 2.1.0
>

I noticed this test is running for MIPS (and probably other non-i386 
targets). Was it really your intention to have this test execute on 
non-i386 targets?


  reply	other threads:[~2015-09-15 14:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-14 17:51 Jan Kratochvil
2015-09-15 14:03 ` Luis Machado [this message]
2015-09-15 14:22   ` Jan Kratochvil
2015-09-15 14:30     ` Luis Machado
2015-09-15 14:35       ` Luis Machado
2015-09-15 14:37         ` Jan Kratochvil
2015-09-15 14:51           ` Luis Machado
2015-09-15 14:58             ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F82526.4020709@codesourcery.com \
    --to=lgustavo@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox