Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: Jon Turney <jon.turney@dronecode.org.uk>
Cc: binutils@sourceware.org, gdb-patches@sourceware.org
Subject: Re: [PATCH] Allow gdb to find debug symbols file by build-id for PE file format also
Date: Mon, 15 Jun 2015 16:34:00 -0000	[thread overview]
Message-ID: <20150615163431.GF23443@vapier> (raw)
In-Reply-To: <1433946324-7600-1-git-send-email-jon.turney@dronecode.org.uk>

[-- Attachment #1: Type: text/plain, Size: 909 bytes --]

On 10 Jun 2015 15:25, Jon Turney wrote:
> --- a/bfd/bfd-in2.h
> +++ b/bfd/bfd-in2.h
> @@ -6322,6 +6322,12 @@ enum bfd_plugin_format
>      bfd_plugin_no = 2
>    };
>  
> +struct bfd_build_id
> +  {
> +    size_t size;
> +    bfd_byte data[1];
> +  };

the use of size_t here breaks a number of targets because this header doesn't 
include the header which provides the definition for it.  it happens to work for 
some due to other files pulling in the right headers, but it's still broken.  i 
don't know what the policy is here in this header as it seems to isolate itself 
from the OS quite a bit.

In file included from ../../../../sim/erc32/../../include/gdb/callback.h:55:0,
                 from ../../../../sim/erc32/sis.h:18,
                 from ../../../../sim/erc32/exec.c:20:
../../bfd/bfd.h:6332:5: error: unknown type name ‘size_t’
     size_t size;
     ^
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2015-06-15 16:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-16 15:37 [PATCH] Find debug symbols file by buildid for coff " Jon TURNEY
2015-03-16 16:30 ` Eli Zaretskii
2015-03-17 12:56   ` Jon TURNEY
2015-04-08 12:17     ` [PATCH] Find debug symbols file by buildid for PE " Jon TURNEY
2015-04-08 12:39       ` Eli Zaretskii
2015-04-22 13:41       ` Jon TURNEY
2015-06-02 13:33       ` Jon TURNEY
2015-06-09 19:36       ` Joel Brobecker
2015-06-10 14:26         ` [PATCH] Allow gdb to find debug symbols file by build-id " Jon Turney
2015-06-12 15:45           ` Nicholas Clifton
2015-06-15 16:34           ` Mike Frysinger [this message]
2015-06-15 18:13             ` Andreas Schwab
2015-06-15 18:25               ` Jon TURNEY
2015-06-16 11:35                 ` Nicholas Clifton
2015-06-17 16:09           ` Yao Qi
2015-06-18 11:05             ` Jon TURNEY

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150615163431.GF23443@vapier \
    --to=vapier@gentoo.org \
    --cc=binutils@sourceware.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jon.turney@dronecode.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox