From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43916 invoked by alias); 15 Jun 2015 16:34:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43829 invoked by uid 89); 15 Jun 2015 16:34:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 15 Jun 2015 16:34:34 +0000 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id E53CF340C92; Mon, 15 Jun 2015 16:34:31 +0000 (UTC) Date: Mon, 15 Jun 2015 16:34:00 -0000 From: Mike Frysinger To: Jon Turney Cc: binutils@sourceware.org, gdb-patches@sourceware.org Subject: Re: [PATCH] Allow gdb to find debug symbols file by build-id for PE file format also Message-ID: <20150615163431.GF23443@vapier> Mail-Followup-To: Jon Turney , binutils@sourceware.org, gdb-patches@sourceware.org References: <20150609193638.GM2855@adacore.com> <1433946324-7600-1-git-send-email-jon.turney@dronecode.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qcHopEYAB45HaUaB" Content-Disposition: inline In-Reply-To: <1433946324-7600-1-git-send-email-jon.turney@dronecode.org.uk> X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00322.txt.bz2 --qcHopEYAB45HaUaB Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 919 On 10 Jun 2015 15:25, Jon Turney wrote: > --- a/bfd/bfd-in2.h > +++ b/bfd/bfd-in2.h > @@ -6322,6 +6322,12 @@ enum bfd_plugin_format > bfd_plugin_no =3D 2 > }; >=20=20 > +struct bfd_build_id > + { > + size_t size; > + bfd_byte data[1]; > + }; the use of size_t here breaks a number of targets because this header doesn= 't=20 include the header which provides the definition for it. it happens to wor= k for=20 some due to other files pulling in the right headers, but it's still broken= . i=20 don't know what the policy is here in this header as it seems to isolate it= self=20 from the OS quite a bit. In file included from ../../../../sim/erc32/../../include/gdb/callback.h:55= :0, from ../../../../sim/erc32/sis.h:18, from ../../../../sim/erc32/exec.c:20: ../../bfd/bfd.h:6332:5: error: unknown type name =E2=80=98size_t=E2=80=99 size_t size; ^ -mike --qcHopEYAB45HaUaB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVfv6WAAoJEEFjO5/oN/WBH1sQAMHCnbBJETVNKJZPDj2wRFX6 +Jf52AweAj5ngukiXG1dFxIbKQ/FkAunsBp+Eio+gLBpIe5nPyX2nqGd0yU9cCm1 u15DV0ocYCfNpyHbtVaVvJsn/f93Qojibe9r3CkfoY2GFajQ7i/Dh1Xpstm3ZRlN q5XAwheb94nArP5M+ymjRpC5cteiqrjS9/OJtyromfly4/gu9fPaY4usj3YL/5YJ 6NA0oTJgs4MS9uOQLDnCD6k5ReZaqE0Tc4oj6w+JYNp6lIYeRvx+pT24JKdD2wvT M/+++BjibzFkL+uhXX4f49W0VjtjEOO39JEF8USWEUaBsvKJQp1wPqq299fbPiUr OZNgfsR1MRQmStAZMBMQSTDG/hU8wev6hvaJX+INc8no+RpvDdNWHcq1HvaGPa/d ALJq/PAmYIgjNIFzGo1N0mrgILkO47t9FqmUvH37tGHGSKCBTXQGBxbFjZvVldio 9hkE22h4G7Mxd8aV9bXA2XiSAibXiPDBAR7CgKBRqa7NUo46V+C+Jq5GBgICJik4 qTqodanlClpZ5tplyh5VfTP410ujcJoMSq2ejHd5gW4fxV3I+GCPusykqMOpG+L6 9qRhxErE/HKZe7o/pXTygcQ80fZa+KX8jS8dVnRBDsl1HEnUxJOZRmPqvJ3pepJ6 RtDlvYEdrbxNXNsWNJC8 =yfZW -----END PGP SIGNATURE----- --qcHopEYAB45HaUaB--