From: Jon TURNEY <jon.turney@dronecode.org.uk>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: binutils@sourceware.org, gdb-patches@sourceware.org
Subject: Re: [PATCH] Allow gdb to find debug symbols file by build-id for PE file format also
Date: Mon, 15 Jun 2015 18:25:00 -0000 [thread overview]
Message-ID: <557F18A5.2080906@dronecode.org.uk> (raw)
In-Reply-To: <87oakgq1pv.fsf@igel.home>
[-- Attachment #1: Type: text/plain, Size: 196 bytes --]
On 15/06/2015 19:13, Andreas Schwab wrote:
> Mike Frysinger <vapier@gentoo.org> writes:
>
>> don't know what the policy is here in this header
>
> It should use bfd_size_type.
Patch attached.
[-- Attachment #2: 0001-Fix-build-when-size_t-is-not-available-in-bfd-in2.h.patch --]
[-- Type: text/plain, Size: 1452 bytes --]
From 9c96da937babaedd5b23ae352359c3caaf8524ad Mon Sep 17 00:00:00 2001
From: Jon Turney <jon.turney@dronecode.org.uk>
Date: Mon, 15 Jun 2015 19:20:02 +0100
Subject: [PATCH] Fix build when size_t is not available in bfd-in2.h
bfd/ChangeLog:
2015-06-15 Jon Turney <jon.turney@dronecode.org.uk>
* bfd.c: Change struct bfd_build_id to use bfd_size_type.
* bfd-in2.h : Regenerate.
Signed-off-by: Jon Turney <jon.turney@dronecode.org.uk>
---
bfd/ChangeLog | 5 +++++
bfd/bfd-in2.h | 2 +-
bfd/bfd.c | 2 +-
3 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 886da5b..265cc41f 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2015-06-15 Jon Turney <jon.turney@dronecode.org.uk>
+
+ * bfd.c: Change struct bfd_build_id to use bfd_size_type.
+ * bfd-in2.h : Regenerate.
+
2015-06-10 Jon Turney <jon.turney@dronecode.org.uk>
* elf-bfd.h : Remove struct elf_build_id.
diff --git a/bfd/bfd-in2.h b/bfd/bfd-in2.h
index dfffe3c..2d32c74 100644
--- a/bfd/bfd-in2.h
+++ b/bfd/bfd-in2.h
@@ -6328,7 +6328,7 @@ enum bfd_plugin_format
struct bfd_build_id
{
- size_t size;
+ bfd_size_type size;
bfd_byte data[1];
};
diff --git a/bfd/bfd.c b/bfd/bfd.c
index e60f358..8d85de5 100644
--- a/bfd/bfd.c
+++ b/bfd/bfd.c
@@ -53,7 +53,7 @@ CODE_FRAGMENT
.
.struct bfd_build_id
. {
-. size_t size;
+. bfd_size_type size;
. bfd_byte data[1];
. };
.
--
2.1.4
next prev parent reply other threads:[~2015-06-15 18:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 15:37 [PATCH] Find debug symbols file by buildid for coff " Jon TURNEY
2015-03-16 16:30 ` Eli Zaretskii
2015-03-17 12:56 ` Jon TURNEY
2015-04-08 12:17 ` [PATCH] Find debug symbols file by buildid for PE " Jon TURNEY
2015-04-08 12:39 ` Eli Zaretskii
2015-04-22 13:41 ` Jon TURNEY
2015-06-02 13:33 ` Jon TURNEY
2015-06-09 19:36 ` Joel Brobecker
2015-06-10 14:26 ` [PATCH] Allow gdb to find debug symbols file by build-id " Jon Turney
2015-06-12 15:45 ` Nicholas Clifton
2015-06-15 16:34 ` Mike Frysinger
2015-06-15 18:13 ` Andreas Schwab
2015-06-15 18:25 ` Jon TURNEY [this message]
2015-06-16 11:35 ` Nicholas Clifton
2015-06-17 16:09 ` Yao Qi
2015-06-18 11:05 ` Jon TURNEY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557F18A5.2080906@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox