From: Eli Zaretskii <eliz@gnu.org>
To: Jon TURNEY <jon.turney@dronecode.org.uk>
Cc: gdb-patches@sourceware.org, jon.turney@dronecode.org.uk
Subject: Re: [PATCH] Find debug symbols file by buildid for coff file format also
Date: Mon, 16 Mar 2015 16:30:00 -0000 [thread overview]
Message-ID: <831tko29ct.fsf@gnu.org> (raw)
In-Reply-To: <1426520230-18940-1-git-send-email-jon.turney@dronecode.org.uk>
> From: Jon TURNEY <jon.turney@dronecode.org.uk>
> Cc: Jon TURNEY <jon.turney@dronecode.org.uk>
> Date: Mon, 16 Mar 2015 15:37:10 +0000
>
> bfd/ChangeLog:
>
> 2015-03-14 Jon TURNEY <jon.turney@dronecode.org.uk>
>
> * elf-bfd.h : Remove struct elf_build_id.
> * bfd.c : Add struct bfd_build_id.
> * bfd-in2.h: Regenerate.
> * elf.c (elfobj_grok_gnu_build_id): Update to use bfd_build_id.
> * libpei.h: Add protoype and macros for
> bfd_XXi_slurp_codeview_record.
> * peXXigen.c (_bfd_XXi_slurp_codeview_record): Make public
> * peicode.h (pe_bfd_read_buildid): Add.
> (pe_bfd_object_p): Use pe_bfd_read_buildid().
>
> gdb/ChangeLog:
>
> 2015-03-14 Jon TURNEY <jon.turney@dronecode.org.uk>
>
> * build-id.c (build_id_bfd_get): Use bfd_build_id.
> (build_id_verify): Ditto.
> * build-id.h: Ditto.
> (find_separate_debug_file_by_buildid): Ditto.
> * python/py-objfile.c (objfpy_get_build_id)
> (objfpy_build_id_matches, objfpy_lookup_objfile_by_build_id): Ditto.
> * coffread.c (coff_symfile_read): Try
> find_separate_debug_file_by_buildid.
>
> gdb/doc/ChangeLog:
>
> 2015-03-14 Jon TURNEY <jon.turney@dronecode.org.uk>
>
> * gdb.texinfo (Separate Debug Files): Document that COFF is also
> supported.
The gdb.texinfo part is OK, except that AFAIK PE is not the same as
COFF, so I suggest to amend the ChangeLog entry above.
Thanks.
next prev parent reply other threads:[~2015-03-16 16:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 15:37 Jon TURNEY
2015-03-16 16:30 ` Eli Zaretskii [this message]
2015-03-17 12:56 ` Jon TURNEY
2015-04-08 12:17 ` [PATCH] Find debug symbols file by buildid for PE " Jon TURNEY
2015-04-08 12:39 ` Eli Zaretskii
2015-04-22 13:41 ` Jon TURNEY
2015-06-02 13:33 ` Jon TURNEY
2015-06-09 19:36 ` Joel Brobecker
2015-06-10 14:26 ` [PATCH] Allow gdb to find debug symbols file by build-id " Jon Turney
2015-06-12 15:45 ` Nicholas Clifton
2015-06-15 16:34 ` Mike Frysinger
2015-06-15 18:13 ` Andreas Schwab
2015-06-15 18:25 ` Jon TURNEY
2015-06-16 11:35 ` Nicholas Clifton
2015-06-17 16:09 ` Yao Qi
2015-06-18 11:05 ` Jon TURNEY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831tko29ct.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=jon.turney@dronecode.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox